From: Michal Swiatkowski <michal.swiatkowski@linux•intel.com>
To: Jakub Kicinski <kuba@kernel•org>
Cc: Michal Swiatkowski <michal.swiatkowski@linux•intel.com>,
Wojciech Drewek <wojciech.drewek@intel•com>,
Kuniyuki Iwashima <kuniyu@amazon•com>,
Andrew Lunn <andrew+netdev@lunn•ch>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Paolo Abeni <pabeni@redhat•com>, Simon Horman <horms@kernel•org>,
Kuniyuki Iwashima <kuni1840@gmail•com>,
netdev@vger•kernel.org, marcin.szycik@intel•com
Subject: Re: [PATCH v2 net-next 2/3] pfcp: Convert pfcp_net_exit() to ->exit_rtnl().
Date: Fri, 25 Apr 2025 06:28:26 +0200 [thread overview]
Message-ID: <aAsPamW5qmCp+O3e@mev-dev.igk.intel.com> (raw)
In-Reply-To: <20250424152638.5915c020@kernel.org>
On Thu, Apr 24, 2025 at 03:26:38PM -0700, Jakub Kicinski wrote:
> On Thu, 24 Apr 2025 06:40:36 +0200 Michal Swiatkowski wrote:
> > > > Uh, I remember that we used it to add tc filter. Maybe we can fix it?
> > >
> > > If it really was broken for over a year and nobody noticed -
> > > my preference would be to delete it. I don't think you need
> > > an actual tunnel dev to add TC filters?
> >
> > Our approach was to follow scheme from exsisting ones.
> > For example, vxlan filter:
> > tc filter add dev vxlan ingress protocol ip ...
> > PFCP filter:
> > tc filter add dev pfcp ingress protocol ip ...
> >
> > so in this case we need sth to point and pass the information that this
> > tunnel is PFCP. If you have an idea how to do it without actual tunnel
> > we are willing to implement it. AFAIR simple matching on specific port
> > number isn't good solution as tunnel specific fields can't be passed in
> > such scenario.
>
> You're right, not sure what I was thinking.. probably about
> the offloaded flow.
>
> Could you please fix this and provide a selftests for offloaded
> and non-offloaded operation? To make sure this code is exercised?
Sure, I will do that. I am going for a two week vacation from today, so it
can take some time for v1.
Thanks
next prev parent reply other threads:[~2025-04-25 4:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-18 0:32 [PATCH v2 net-next 0/3] net: Followup series for ->exit_rtnl() Kuniyuki Iwashima
2025-04-18 0:32 ` [PATCH v2 net-next 1/3] net: Drop hold_rtnl arg from ops_undo_list() Kuniyuki Iwashima
2025-04-18 0:32 ` [PATCH v2 net-next 2/3] pfcp: Convert pfcp_net_exit() to ->exit_rtnl() Kuniyuki Iwashima
2025-04-23 2:47 ` Jakub Kicinski
2025-04-23 8:37 ` Michal Swiatkowski
2025-04-23 13:33 ` Jakub Kicinski
2025-04-24 4:40 ` Michal Swiatkowski
2025-04-24 22:26 ` Jakub Kicinski
2025-04-25 4:28 ` Michal Swiatkowski [this message]
2025-04-23 13:40 ` Jakub Kicinski
2025-04-23 14:12 ` Kuniyuki Iwashima
2025-04-23 22:33 ` Jakub Kicinski
2025-04-23 22:52 ` Jakub Kicinski
2025-04-24 2:23 ` Kuniyuki Iwashima
2025-04-24 22:24 ` Jakub Kicinski
2025-04-18 0:32 ` [PATCH v2 net-next 3/3] ppp: Split ppp_exit_net() " Kuniyuki Iwashima
2025-04-23 2:50 ` [PATCH v2 net-next 0/3] net: Followup series for ->exit_rtnl() patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aAsPamW5qmCp+O3e@mev-dev.igk.intel.com \
--to=michal.swiatkowski@linux$(echo .)intel.com \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=kuni1840@gmail$(echo .)com \
--cc=kuniyu@amazon$(echo .)com \
--cc=marcin.szycik@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=wojciech.drewek@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox