From: Simon Horman <horms@kernel•org>
To: Dimitri Daskalakis <dimitri.daskalakis1@gmail•com>
Cc: "David S . Miller" <davem@davemloft•net>,
Jakub Kicinski <kuba@kernel•org>,
Alexander Duyck <alexanderduyck@fb•com>,
netdev@vger•kernel.org
Subject: Re: [PATCH net-next 1/2] net: fbnic: Fix page chunking logic when PAGE_SIZE > 4K
Date: Tue, 14 Oct 2025 13:44:49 +0100 [thread overview]
Message-ID: <aO5FwdsNaO_H7s8i@horms.kernel.org> (raw)
In-Reply-To: <20251013211449.1377054-2-dimitri.daskalakis1@gmail.com>
On Mon, Oct 13, 2025 at 02:14:48PM -0700, Dimitri Daskalakis wrote:
> The HW always works on a 4K page size. When the OS supports larger
> pages, we fragment them across multiple BDQ descriptors.
> We were not properly incrementing the descriptor, which resulted in us
> specifying the last chunks id/addr and then 15 zero descriptors. This
> would cause packet loss and driver crashes. This is not a fix since the
> Kconfig prevents use outside of x86.
>
> Signed-off-by: Dimitri Daskalakis <dimitri.daskalakis1@gmail•com>
> Signed-off-by: Jakub Kicinski <kuba@kernel•org>
Reviewed-by: Simon Horman <horms@kernel•org>
next prev parent reply other threads:[~2025-10-14 12:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-13 21:14 [PATCH net-next 0/2] Add aarch64 support for FBNIC Dimitri Daskalakis
2025-10-13 21:14 ` [PATCH net-next 1/2] net: fbnic: Fix page chunking logic when PAGE_SIZE > 4K Dimitri Daskalakis
2025-10-14 12:44 ` Simon Horman [this message]
2025-10-13 21:14 ` [PATCH net-next 2/2] net: fbnic: Allow builds for all 64 bit architectures Dimitri Daskalakis
2025-10-14 12:45 ` Simon Horman
2025-10-16 9:50 ` [PATCH net-next 0/2] Add aarch64 support for FBNIC patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aO5FwdsNaO_H7s8i@horms.kernel.org \
--to=horms@kernel$(echo .)org \
--cc=alexanderduyck@fb$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dimitri.daskalakis1@gmail$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox