Subject: Re: [net-next v8 3/3] net: bonding: send peer notify when failure recovery

From: Hangbin Liu <[email-masked]>
Date: Wed, 15 Oct 2025 03:36:18 +0000

On Fri, Jun 27, 2025 at 09:49:30PM +0800, Tonghao Zhang wrote:
> +static void ad_cond_set_peer_notif(struct port *port)
> +{
> +	struct bonding *bond = port->slave->bond;
> +
> +	if (bond->params.broadcast_neighbor && rtnl_trylock()) {

Hi Tonghao,

When do our internal review, Antoine pointed that this rtnl_trylock() may
fail and cause the notify not send. The other places of bonding using
workqueues to reschedule when the rtnl_trylock() failed. Do you think
if we should also do some similar thing to avoid notify failed?

Thanks
Hangbin
> +		bond->send_peer_notif = bond->params.num_peer_notif *
> +			max(1, bond->params.peer_notif_delay);
> +		rtnl_unlock();
> +	}
> +}