Subject: Re: [net,PATCH] net: phy: realtek: Avoid PHYCR2 access if PHYCR2 not present

From: "Russell King (Oracle)" <[email-masked]>
Date: Mon, 13 Oct 2025 13:35:50 +0100

On Sat, Oct 11, 2025 at 01:02:49PM +0200, Marek Vasut wrote:
> The driver is currently checking for PHYCR2 register presence in
> rtl8211f_config_init(), but it does so after accessing PHYCR2 to
> disable EEE. This was introduced in commit bfc17c165835 ("net:
> phy: realtek: disable PHY-mode EEE"). Move the PHYCR2 presence
> test before the EEE disablement and simplify the code.
> 
> Fixes: bfc17c165835 ("net: phy: realtek: disable PHY-mode EEE")
> Signed-off-by: Marek Vasut <[email-masked]>

This looks obvious.

Reviewed-by: Russell King (Oracle) <[email-masked]>

Thanks!

> Cc: "David S. Miller" <[email-masked]>
> Cc: Andrew Lunn <[email-masked]>
> Cc: Daniel Golle <[email-masked]>
> Cc: Eric Dumazet <[email-masked]>
> Cc: Heiner Kallweit <[email-masked]>
> Cc: Jakub Kicinski <[email-masked]>
> Cc: Markus Stockhausen <[email-masked]>
> Cc: Michael Klein <[email-masked]>
> Cc: Paolo Abeni <[email-masked]>
> Cc: Russell King <[email-masked]>

Please drop this line.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!