From: Hangbin Liu <liuhangbin@gmail•com>
To: Tonghao Zhang <tonghao@bamaicloud•com>
Cc: netdev@vger•kernel.org, Jay Vosburgh <jv@jvosburgh•net>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
Simon Horman <horms@kernel•org>, Jonathan Corbet <corbet@lwn•net>,
Andrew Lunn <andrew+netdev@lunn•ch>,
Nikolay Aleksandrov <razor@blackwall•org>,
Jiri Slaby <jirislaby@kernel•org>,
stable@vger•kernel.org
Subject: Re: [PATCH] net: bonding: update the slave array for broadcast mode
Date: Thu, 16 Oct 2025 05:51:14 +0000 [thread overview]
Message-ID: <aPCH0vHFqHmBQY_i@fedora> (raw)
In-Reply-To: <20251015125808.53728-1-tonghao@bamaicloud.com>
Hi Tonghao,
Please add the target repo in the subject. e.g.
[PATCH net] net: bonding: update the slave array for broadcast mode
The patch looks good to me.
On Wed, Oct 15, 2025 at 08:58:08PM +0800, Tonghao Zhang wrote:
> This patch fixes ce7a381697cb ("net: bonding: add broadcast_neighbor option for 802.3ad").
> Before this commit, on the broadcast mode, all devices were traversed using the
> bond_for_each_slave_rcu. This patch supports traversing devices by using all_slaves.
> Therefore, we need to update the slave array when enslave or release salve.
>
> Fixes: ce7a381697cb ("net: bonding: add broadcast_neighbor option for 802.3ad")
> Cc: Jay Vosburgh <jv@jvosburgh•net>
> Cc: "David S. Miller" <davem@davemloft•net>
> Cc: Eric Dumazet <edumazet@google•com>
> Cc: Jakub Kicinski <kuba@kernel•org>
> Cc: Paolo Abeni <pabeni@redhat•com>
> Cc: Simon Horman <horms@kernel•org>
> Cc: Jonathan Corbet <corbet@lwn•net>
> Cc: Andrew Lunn <andrew+netdev@lunn•ch>
> Cc: Nikolay Aleksandrov <razor@blackwall•org>
> Cc: Hangbin Liu <liuhangbin@gmail•com>
> Cc: Jiri Slaby <jirislaby@kernel•org>
> Cc: <stable@vger•kernel.org>
> Signed-off-by: Tonghao Zhang <tonghao@bamaicloud•com>
> ---
> drivers/net/bonding/bond_main.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
> index 17c7542be6a5..2d6883296e32 100644
> --- a/drivers/net/bonding/bond_main.c
> +++ b/drivers/net/bonding/bond_main.c
> @@ -2384,7 +2384,9 @@ int bond_enslave(struct net_device *bond_dev, struct net_device *slave_dev,
> unblock_netpoll_tx();
> }
>
> - if (bond_mode_can_use_xmit_hash(bond))
> + /* broadcast mode uses the all_slaves to loop through slaves. */
> + if (bond_mode_can_use_xmit_hash(bond) ||
> + BOND_MODE(bond) == BOND_MODE_BROADCAST)
> bond_update_slave_arr(bond, NULL);
>
> if (!slave_dev->netdev_ops->ndo_bpf ||
> @@ -2560,7 +2562,8 @@ static int __bond_release_one(struct net_device *bond_dev,
>
> bond_upper_dev_unlink(bond, slave);
>
> - if (bond_mode_can_use_xmit_hash(bond))
> + if (bond_mode_can_use_xmit_hash(bond) ||
> + BOND_MODE(bond) == BOND_MODE_BROADCAST)
> bond_update_slave_arr(bond, slave);
>
> slave_info(bond_dev, slave_dev, "Releasing %s interface\n",
> --
> 2.34.1
>
Reviewed-by: Hangbin Liu <liuhangbin@gmail•com>
next prev parent reply other threads:[~2025-10-16 5:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-15 12:58 [PATCH] net: bonding: update the slave array for broadcast mode Tonghao Zhang
2025-10-16 5:49 ` Jiri Slaby
2025-10-16 5:51 ` Hangbin Liu [this message]
2025-10-16 12:56 ` Tonghao Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPCH0vHFqHmBQY_i@fedora \
--to=liuhangbin@gmail$(echo .)com \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=corbet@lwn$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=jirislaby@kernel$(echo .)org \
--cc=jv@jvosburgh$(echo .)net \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=razor@blackwall$(echo .)org \
--cc=stable@vger$(echo .)kernel.org \
--cc=tonghao@bamaicloud$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox