From: Simon Horman <horms@kernel•org>
To: Vadim Fedorenko <vadim.fedorenko@linux•dev>
Cc: Shyam Sundar S K <Shyam-sundar.S-k@amd•com>,
Andrew Lunn <andrew+netdev@lunn•ch>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
Egor Pomozov <epomozov@marvell•com>,
Potnuri Bharat Teja <bharat@chelsio•com>,
Dimitris Michailidis <dmichail@fungible•com>,
MD Danish Anwar <danishanwar@ti•com>,
Roger Quadros <rogerq@kernel•org>,
Richard Cochran <richardcochran@gmail•com>,
Russell King <linux@armlinux•org.uk>,
Vladimir Oltean <vladimir.oltean@nxp•com>,
netdev@vger•kernel.org
Subject: Re: [PATCH net-next v2 5/7] cxgb4: convert to ndo_hwtstamp API
Date: Thu, 16 Oct 2025 09:10:34 +0100 [thread overview]
Message-ID: <aPCoekdo1PwB9Upm@horms.kernel.org> (raw)
In-Reply-To: <1639cc31-b57f-4370-8062-6a06252451f0@linux.dev>
On Wed, Oct 15, 2025 at 09:05:16PM +0100, Vadim Fedorenko wrote:
> On 15.10.2025 15:37, Simon Horman wrote:
> > On Wed, Oct 15, 2025 at 11:33:02AM +0100, Vadim Fedorenko wrote:
> > > On 15/10/2025 11:05, Simon Horman wrote:
> > > > On Tue, Oct 14, 2025 at 10:42:14PM +0000, Vadim Fedorenko wrote:
> > > > > Convert to use .ndo_hwtstamp_get()/.ndo_hwtstamp_set() callbacks.
> > > > >
> > > > > Though I'm not quite sure it worked properly before the conversion.
> > > > >
> > > > > Signed-off-by: Vadim Fedorenko <vadim.fedorenko@linux•dev>
> > > >
> > > > Hi Vadim,
> > > >
> > > > There is quite a lot of change here. Probably it's not worth "fixing"
> > > > the current code before migrating it. But I think it would be worth
> > > > expanding a bit on the statement about not being sure it worked?
> > >
> > > Hi Simon!
> > >
> > > Well, let me try to explain the statement about not being sure it
> > > worked. The original code was copying new configuration into netdev's
> > > private structure before validating that the values are acceptable by
> > > the hardware. In case of error, the driver was not restoring original
> > > values, and after the call:
> > >
> > > ioctl(SIOCSHWTSTAMP, <unsupported_config>) = -ERANGE
> > >
> > > the driver would have configuration which could not be reapplied and not
> > > synced to the actual hardware config:
> > >
> > > ioctl(SIOCGHWTSTAMP) = <unsupported_config>
> > >
> > > The logic change in the patch is to just keep original configuration in
> > > case of -ERANGE error. Otherwise the logic is not changed.
> >
> > Thanks Vadim,
> >
> > I see that now and it makes sense to me.
> > I do think it would be worth mentioning in the patch description.
>
> Fair point, I'll update commit message for v3.
Thanks, much appreciated.
next prev parent reply other threads:[~2025-10-16 8:10 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-14 22:42 [PATCH net-next v2 0/7] convert net drivers to ndo_hwtstamp API part 1 Vadim Fedorenko
2025-10-14 22:42 ` [PATCH net-next v2 1/7] net: ti: am65-cpsw: move hw timestamping to ndo callback Vadim Fedorenko
2025-10-15 14:39 ` Simon Horman
2025-10-15 19:45 ` Jacob Keller
2025-10-14 22:42 ` [PATCH net-next v2 2/7] ti: icssg: convert to ndo_hwtstamp API Vadim Fedorenko
2025-10-15 14:39 ` Simon Horman
2025-10-15 19:46 ` Jacob Keller
2025-10-14 22:42 ` [PATCH net-next v2 3/7] amd-xgbe: convert to ndo_hwtstamp callbacks Vadim Fedorenko
2025-10-15 14:40 ` Simon Horman
2025-10-15 19:47 ` Jacob Keller
2025-10-15 19:58 ` Vadim Fedorenko
2025-10-15 20:23 ` Jacob Keller
2025-10-14 22:42 ` [PATCH net-next v2 4/7] net: atlantic: convert to ndo_hwtstamp API Vadim Fedorenko
2025-10-15 14:40 ` Simon Horman
2025-10-15 19:49 ` Jacob Keller
2025-10-14 22:42 ` [PATCH net-next v2 5/7] cxgb4: " Vadim Fedorenko
2025-10-15 10:05 ` Simon Horman
2025-10-15 10:33 ` Vadim Fedorenko
2025-10-15 14:37 ` Simon Horman
2025-10-15 20:05 ` Vadim Fedorenko
2025-10-16 8:10 ` Simon Horman [this message]
2025-10-15 20:18 ` Jacob Keller
2025-10-14 22:42 ` [PATCH net-next v2 6/7] tsnep: convert to ndo_hwtstatmp API Vadim Fedorenko
2025-10-15 10:03 ` Simon Horman
2025-10-15 10:38 ` Vadim Fedorenko
2025-10-15 14:38 ` Simon Horman
2025-10-14 22:42 ` [PATCH net-next v2 7/7] funeth: convert to ndo_hwtstamp API Vadim Fedorenko
2025-10-15 14:40 ` Simon Horman
2025-10-15 20:20 ` Jacob Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPCoekdo1PwB9Upm@horms.kernel.org \
--to=horms@kernel$(echo .)org \
--cc=Shyam-sundar.S-k@amd$(echo .)com \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=bharat@chelsio$(echo .)com \
--cc=danishanwar@ti$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dmichail@fungible$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=epomozov@marvell$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=richardcochran@gmail$(echo .)com \
--cc=rogerq@kernel$(echo .)org \
--cc=vadim.fedorenko@linux$(echo .)dev \
--cc=vladimir.oltean@nxp$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox