Subject: Re: [PATCH iwl-net v2] libie: depend on DEBUG_FS when building LIBIE_FWLOG

From: Simon Horman <[email-masked]>
Date: Thu, 16 Oct 2025 17:08:52 +0100

On Thu, Oct 16, 2025 at 09:29:40AM +0200, Michal Swiatkowski wrote:
> LIBIE_FWLOG is unusable without DEBUG_FS. Mark it in Kconfig.
> 
> Fix build error on ixgbe when DEBUG_FS is not set. To not add another
> layer of #if IS_ENABLED(LIBIE_FWLOG) in ixgbe fwlog code define debugfs
> dentry even when DEBUG_FS isn't enabled. In this case the dummy
> functions of LIBIE_FWLOG will be used, so not initialized dentry isn't a
> problem.
> 
> Fixes: 641585bc978e ("ixgbe: fwlog support for e610")
> Reported-by: Guenter Roeck <[email-masked]>
> Closes: https://lore.kernel.org/lkml/[email-masked]/
> Signed-off-by: Michal Swiatkowski <[email-masked]>
> ---
> v1 --> v2 [1]:
>  * add DEBUG_FS dependency in LIBIE_FWLOG
> 
> [1] https://lore.kernel.org/netdev/[email-masked]/

I lightly compile-tested this and overall it looks good to me.

Reviewed-by: Simon Horman <[email-masked]>