Subject: Re: [PATCH net v2 1/3] net: datagram: introduce datagram_poll_queue for custom receive queues

From: Sabrina Dubroca <[email-masked]>
Date: Mon, 20 Oct 2025 12:17:31 +0200

LGTM, just a small nit:

2025-10-20, 09:37:29 +0200, Ralf Lici wrote:
> +/**
> + *	datagram_poll - generic datagram poll
> + *	@file: file struct
> + *	@sock: socket
> + *	@wait: poll table
> + *
> + *	Datagram poll: Again totally generic. This also handles
> + *	sequenced packet sockets providing the socket receive queue
> + *	is only ever holding data ready to receive.
> + *
> + *	Note: when you *don't* use this routine for this protocol,
> + *	and you use a different write policy from sock_writeable()
> + *	then please supply your own write_space callback.

Maybe you could document the return value here as well, since you're
touching this code.

> + */
> +__poll_t datagram_poll(struct file *file, struct socket *sock, poll_table *wait)

-- 
Sabrina