Subject: Re: [PATCH net-next v2]: 3c515 : replace cleanup_module with __exit

From: Simon Horman <[email-masked]>
Date: Mon, 20 Oct 2025 13:56:15 +0100

On Sat, Oct 18, 2025 at 10:55:41AM +0530, Shi Hao wrote:
> update old legacy cleanup_module from the file with __exit
> module as per kernel code practices and restore the #ifdef
> MODULE condition to allow successful compilation as a built
> -in driver.
> 
> The file had an old cleanup_module still in use which could
> be updated with __exit module function although its init_module
> is indeed newer however the cleanup_module was still
> using the older version of exit.
> 
> To set proper exit module function replace cleanup_module
> with __exit corkscrew_exit_module to align it to the
> kernel code consistency.
> 
> Signed-off-by: Shi Hao <[email-masked]>
> 
> ---
> 
> changes v2:
> - Restore ifdef module condition to compile as built in module
> - Adjust subject prefix from "net:ethernet" to "3c515"

Thanks for the update.
The code changes in this version look good to me.

One minor nit: the whitespace in the subject look slightly off.
There is probably no need to repost because of this.
But I would have gone for:

Subject: [PATCH net-next v2] 3c515: replace cleanup_module with __exit

But overall this looks good to me.

Reviewed-by: Simon Horman <[email-masked]>