public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed

From: Florian Westphal <fw@strlen•de>
To: Andrii Melnychenko <a.melnychenko@vyos•io>
Cc: pablo@netfilter•org, kadlec@netfilter•org, phil@nwl•cc,
	davem@davemloft•net, edumazet@google•com, kuba@kernel•org,
	pabeni@redhat•com, horms@kernel•org,
	netfilter-devel@vger•kernel.org, coreteam@netfilter•org,
	netdev@vger•kernel.org, linux-kernel@vger•kernel.org
Subject: Re: [PATCH v3 1/1] nft_ct: Added nfct_seqadj_ext_add() for NAT'ed conntrack.
Date: Tue, 21 Oct 2025 16:34:46 +0200	[thread overview]
Message-ID: <aPeZ_4bano8JJigk@strlen.de> (raw)
In-Reply-To: <20251021133918.500380-2-a.melnychenko@vyos.io>

Andrii Melnychenko <a.melnychenko@vyos•io> wrote:
>  
>  struct nft_ct_helper_obj  {
>  	struct nf_conntrack_helper *helper4;
> @@ -1173,6 +1174,9 @@ static void nft_ct_helper_obj_eval(struct nft_object *obj,
>  	if (help) {
>  		rcu_assign_pointer(help->helper, to_assign);
>  		set_bit(IPS_HELPER_BIT, &ct->status);
> +
> +		if ((ct->status & IPS_NAT_MASK) && !nfct_seqadj(ct))
> +			nfct_seqadj_ext_add(ct);

Any reason why you removed the drop logic of earlier versions?

I think this needs something like this:

	if (!nfct_seqadj_ext_add(ct))
           regs->verdict.code = NF_DROP;

so client will eventually retransmit the connection request.

I can also mangle this locally, let me know.

next prev parent reply	other threads:[~2025-10-21 14:34 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-21 13:39 [PATCH v3 0/1] nf_conntrack_ftp: Added nfct_seqadj_ext_add() Andrii Melnychenko
2025-10-21 13:39 ` [PATCH v3 1/1] nft_ct: Added nfct_seqadj_ext_add() for NAT'ed conntrack Andrii Melnychenko
2025-10-21 14:34   ` Florian Westphal [this message]
2025-10-21 16:24     ` Andrii Melnychenko
2025-10-21 16:34       ` Florian Westphal
2025-10-22  0:11     ` Pablo Neira Ayuso
2025-10-22 11:14       ` Florian Westphal
2025-10-22 13:01         ` Andrii Melnychenko
2025-10-23 12:28           ` Andrii Melnychenko
2025-10-23 12:42             ` Florian Westphal
2025-10-24 12:26               ` Andrii Melnychenko
2025-10-24 12:58                 ` Florian Westphal
2025-10-21 14:35 ` [PATCH v3 0/1] nf_conntrack_ftp: Added nfct_seqadj_ext_add() Florian Westphal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aPeZ_4bano8JJigk@strlen.de \
    --to=fw@strlen$(echo .)de \
    --cc=a.melnychenko@vyos$(echo .)io \
    --cc=coreteam@netfilter$(echo .)org \
    --cc=davem@davemloft$(echo .)net \
    --cc=edumazet@google$(echo .)com \
    --cc=horms@kernel$(echo .)org \
    --cc=kadlec@netfilter$(echo .)org \
    --cc=kuba@kernel$(echo .)org \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=netfilter-devel@vger$(echo .)kernel.org \
    --cc=pabeni@redhat$(echo .)com \
    --cc=pablo@netfilter$(echo .)org \
    --cc=phil@nwl$(echo .)cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox