From: Simon Horman <horms@kernel•org>
To: Alok Tiwari <alok.a.tiwari@oracle•com>
Cc: anthony.l.nguyen@intel•com, przemyslaw.kitszel@intel•com,
andrew+netdev@lunn•ch, kuba@kernel•org, davem@davemloft•net,
edumazet@google•com, pabeni@redhat•com,
intel-wired-lan@lists•osuosl.org, netdev@vger•kernel.org,
alok.a.tiwarilinux@gmail•com
Subject: Re: [PATCH net-next 2/2] idpf: fix typos and correct doc comments in idpf driver
Date: Wed, 22 Oct 2025 15:40:13 +0100 [thread overview]
Message-ID: <aPjszTp0QCYowpKy@horms.kernel.org> (raw)
In-Reply-To: <20251021184108.2390121-2-alok.a.tiwari@oracle.com>
On Tue, Oct 21, 2025 at 11:40:55AM -0700, Alok Tiwari wrote:
...
> diff --git a/drivers/net/ethernet/intel/idpf/idpf_singleq_txrx.c b/drivers/net/ethernet/intel/idpf/idpf_singleq_txrx.c
> index 61e613066140..ffc24a825129 100644
> --- a/drivers/net/ethernet/intel/idpf/idpf_singleq_txrx.c
> +++ b/drivers/net/ethernet/intel/idpf/idpf_singleq_txrx.c
> @@ -1029,7 +1029,7 @@ static void idpf_xdp_run_pass(struct libeth_xdp_buff *xdp,
> * @rx_q: rx queue to clean
> * @budget: Total limit on number of packets to process
> *
> - * Returns true if there's any budget left (e.g. the clean is finished)
> + * Returns number of packets cleaned from this queue
Hi Alok,
Perhaps while this line is being updated it could
also be changed to use "Return:" or "Returns:".
Flagged by ./scripts/kernel-doc -none -Wall
> */
> static int idpf_rx_singleq_clean(struct idpf_rx_queue *rx_q, int budget)
> {
> --
> 2.50.1
>
next prev parent reply other threads:[~2025-10-22 14:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-21 18:40 [PATCH net-next 1/2] idpf: correct queue index in Rx allocation error messages Alok Tiwari
2025-10-21 18:40 ` [PATCH net-next 2/2] idpf: fix typos and correct doc comments in idpf driver Alok Tiwari
2025-10-22 14:40 ` Simon Horman [this message]
2025-10-22 15:05 ` [External] : " ALOK TIWARI
2025-10-22 14:38 ` [PATCH net-next 1/2] idpf: correct queue index in Rx allocation error messages Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPjszTp0QCYowpKy@horms.kernel.org \
--to=horms@kernel$(echo .)org \
--cc=alok.a.tiwari@oracle$(echo .)com \
--cc=alok.a.tiwarilinux@gmail$(echo .)com \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=anthony.l.nguyen@intel$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=intel-wired-lan@lists$(echo .)osuosl.org \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=przemyslaw.kitszel@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox