Subject: Re: [PATCH net-next 2/6] net: phy: add phy_may_wakeup()

From: "Russell King (Oracle)" <[email-masked]>
Date: Wed, 22 Oct 2025 19:20:42 +0100

On Wed, Oct 22, 2025 at 03:43:20PM +0200, Maxime Chevallier wrote:
> Hi Russell,
> 
> That's not exactly what's happening, this suggest this is merely a
> wrapper around device_may_wakeup().
> 
> I don't think it's worth blocking the series though, but if you need to
> respin maybe this could be reworded.
> 
> Reviewed-by: Maxime Chevallier <[email-masked]>

I've updated the description as I think patch 4 needs a repost:

+/**
+ * phy_may_wakeup() - indicate whether PHY has wakeup enabled
+ * @phydev: The phy_device struct
+ *
+ * Returns: true/false depending on the PHY driver's device_set_wakeup_enabled()
+ * setting if using the driver model, otherwise the legacy determination.
+ */
+bool phy_may_wakeup(struct phy_device *phydev);
+

Do you want me to still add your r-b?

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!