From: Simon Horman <horms@kernel•org>
To: Eric Dumazet <edumazet@google•com>
Cc: Yonglong Li <liyonglong@chinatelecom•cn>,
netdev@vger•kernel.org, davem@davemloft•net, dsahern@kernel•org,
pabeni@redhat•com, kuba@kernel•org
Subject: Re: [PATH net 1/2] net: ip: add drop reasons when handling ip fragments
Date: Fri, 24 Oct 2025 16:57:23 +0100 [thread overview]
Message-ID: <aPuh49HWMxXNxsyM@horms.kernel.org> (raw)
In-Reply-To: <CANn89i+TsY67y-pCkOkJHsh11Leg77Ek7n2-j6X6ed-U20eR=g@mail.gmail.com>
On Thu, Oct 23, 2025 at 11:43:25PM -0700, Eric Dumazet wrote:
> On Thu, Oct 23, 2025 at 11:23 PM Yonglong Li <liyonglong@chinatelecom•cn> wrote:
> >
> > 1, add new drop reason FRAG_FAILED, and use it in ip_do_fragment
> > 2, use drop reasons PKT_TOO_BIG in ip_fragment
> >
> > Signed-off-by: Yonglong Li <liyonglong@chinatelecom•cn>
> > ---
> > include/net/dropreason-core.h | 3 +++
> > net/ipv4/ip_output.c | 6 +++---
> > 2 files changed, 6 insertions(+), 3 deletions(-)
> >
> > diff --git a/include/net/dropreason-core.h b/include/net/dropreason-core.h
> > index 58d91cc..7da80f4 100644
> > --- a/include/net/dropreason-core.h
> > +++ b/include/net/dropreason-core.h
> > @@ -99,6 +99,7 @@
> > FN(DUP_FRAG) \
> > FN(FRAG_REASM_TIMEOUT) \
> > FN(FRAG_TOO_FAR) \
> > + FN(FRAG_FAILED) \
> > FN(TCP_MINTTL) \
> > FN(IPV6_BAD_EXTHDR) \
> > FN(IPV6_NDISC_FRAG) \
> > @@ -500,6 +501,8 @@ enum skb_drop_reason {
> > * (/proc/sys/net/ipv4/ipfrag_max_dist)
> > */
> > SKB_DROP_REASON_FRAG_TOO_FAR,
> > + /* do ip/ip6 fragment failed */
nit; This comment should be a Kernel doc, like the comments
for other members of this enum.
> > + SKB_DROP_REASON_FRAG_FAILED,
> > /**
> > * @SKB_DROP_REASON_TCP_MINTTL: ipv4 ttl or ipv6 hoplimit below
> > * the threshold (IP_MINTTL or IPV6_MINHOPCOUNT).
...
next prev parent reply other threads:[~2025-10-24 15:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-24 6:23 [PATH net 0/2] add drop reason when do fragment Yonglong Li
2025-10-24 6:23 ` [PATH net 1/2] net: ip: add drop reasons when handling ip fragments Yonglong Li
2025-10-24 6:43 ` Eric Dumazet
2025-10-24 9:56 ` YonglongLi
2025-10-24 15:57 ` Simon Horman [this message]
2025-10-24 6:23 ` [PATH net 2/2] net: ipv6: use drop reasons in ip6_fragment Yonglong Li
2025-10-24 6:45 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPuh49HWMxXNxsyM@horms.kernel.org \
--to=horms@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=dsahern@kernel$(echo .)org \
--cc=edumazet@google$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=liyonglong@chinatelecom$(echo .)cn \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox