Subject: Re: [PATCH net] selftests: netdevsim: Fix ethtool-coalesce.sh fail by installing ethtool-common.sh

From: Simon Horman <[email-masked]>
Date: Tue, 28 Oct 2025 17:14:03 +0000

On Mon, Oct 27, 2025 at 12:30:07PM +0800, Wang Liang wrote:
> The script "ethtool-common.sh" is not installed in INSTALL_PATH, and
> triggers some errors when I try to run the test
> 'drivers/net/netdevsim/ethtool-coalesce.sh':
> 
>   TAP version 13
>   1..1
>   # timeout set to 600
>   # selftests: drivers/net/netdevsim: ethtool-coalesce.sh
>   # ./ethtool-coalesce.sh: line 4: ethtool-common.sh: No such file or directory
>   # ./ethtool-coalesce.sh: line 25: make_netdev: command not found
>   # ethtool: bad command line argument(s)
>   # ./ethtool-coalesce.sh: line 124: check: command not found
>   # ./ethtool-coalesce.sh: line 126: [: -eq: unary operator expected
>   # FAILED /0 checks
>   not ok 1 selftests: drivers/net/netdevsim: ethtool-coalesce.sh # exit=1
> 
> Install this file to avoid this error. After this patch:
> 
>   TAP version 13
>   1..1
>   # timeout set to 600
>   # selftests: drivers/net/netdevsim: ethtool-coalesce.sh
>   # PASSED all 22 checks
>   ok 1 selftests: drivers/net/netdevsim: ethtool-coalesce.sh
> 
> Fixes: fbb8531e58bd ("selftests: extract common functions in ethtool-common.sh")
> Signed-off-by: Wang Liang <[email-masked]>
> ---
>  tools/testing/selftests/drivers/net/netdevsim/Makefile | 2 ++
>  1 file changed, 2 insertions(+)
> 

> diff --git a/tools/testing/selftests/drivers/net/netdevsim/Makefile b/tools/testing/selftests/drivers/net/netdevsim/Makefile
> index daf51113c827..653141a654a0 100644
> --- a/tools/testing/selftests/drivers/net/netdevsim/Makefile
> +++ b/tools/testing/selftests/drivers/net/netdevsim/Makefile
> @@ -20,4 +20,6 @@ TEST_PROGS := \
>  	udp_tunnel_nic.sh \
>  # end of TEST_PROGS
>  
> +TEST_FILES := ethtool-common.sh
> +
>  include ../../../lib.mk

Hi Wang Liang,

As per commit f07f91a36090 ("selftests: net: unify the Makefile formats")
I think the desired format is as follows (completely untested!):

TEST_FILES := \
	ethtool-common.sh \
# end of TEST_PROGS

-- 
pw-bot: changes-requested