Subject: Re: [PATCH v2 net-next] net: stmmac: mdio: fix incorrect phy address check

From: Simon Horman <[email-masked]>
Date: Tue, 28 Oct 2025 15:03:05 +0000

On Sat, Oct 25, 2025 at 08:35:47PM +0200, Heiner Kallweit wrote:
> max_addr is the max number of addresses, not the highest possible address,
> therefore check phydev->mdio.addr > max_addr isn't correct.
> To fix this change the semantics of max_addr, so that it represents
> the highest possible address. IMO this is also a little bit more intuitive
> wrt name max_addr.
> 
> Fixes: 4a107a0e8361 ("net: stmmac: mdio: use phy_find_first to simplify stmmac_mdio_register")
> Reported-by: Dan Carpenter <[email-masked]>
> Reported-by: Simon Horman <[email-masked]>
> Signed-off-by: Heiner Kallweit <[email-masked]>
> ---
> v2:
> - improve subject

Thanks, this versions looks good to me.

Reviewed-by: Simon Horman <[email-masked]>

...