Subject: Re: [PATCH] atm: solos-pci: Use pointer from memcpy() call for assignment in fpga_tx()

From: Simon Horman <[email-masked]>
Date: Mon, 3 Nov 2025 14:32:31 +0000

On Fri, Oct 31, 2025 at 12:42:09PM +0100, Markus Elfring wrote:
> From: Markus Elfring <[email-masked]>
> Date: Fri, 31 Oct 2025 12:30:38 +0100
> 
> A pointer was assigned to a variable. The same pointer was used for
> the destination parameter of a memcpy() call.
> This function is documented in the way that the same value is returned.
> Thus convert two separate statements into a direct variable assignment for
> the return value from a memory copy action.
> 
> The source code was transformed by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <[email-masked]>

Quoting documentation:

1.6.6. Clean-up patches¶

Netdev discourages patches which perform simple clean-ups, which are not in
the context of other work. For example:

 * Addressing checkpatch.pl, and other trivial coding style warnings

 * Addressing Local variable ordering issues

 * Conversions to device-managed APIs (devm_ helpers)

This is because it is felt that the churn that such changes produce comes
at a greater cost than the value of such clean-ups.

Conversely, spelling and grammar fixes are not discouraged.

https://docs.kernel.org/6.18-rc4/process/maintainer-netdev.html#clean-up-patches

-- 
pw-bot: rejected