Subject: Re: [net-next PATCH v2 08/11] fbnic: Cleanup handling for link down event statistics

From: "Russell King (Oracle)" <[email-masked]>
Date: Mon, 3 Nov 2025 17:49:52 +0000

On Mon, Nov 03, 2025 at 09:00:54AM -0800, Alexander Duyck wrote:
> @@ -86,10 +86,10 @@ static int fbnic_stop(struct net_device *netdev)
>  {
>  	struct fbnic_net *fbn = netdev_priv(netdev);
>  
> +	fbnic_mac_free_irq(fbn->fbd);
>  	phylink_suspend(fbn->phylink, fbnic_bmc_present(fbn->fbd));
>  
>  	fbnic_down(fbn);
> -	fbnic_mac_free_irq(fbn->fbd);

This change makes no sense to me, and doesn't seem to be described in
the commit message.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!