From: Ido Schimmel <idosch@nvidia•com>
To: Nikolay Aleksandrov <razor@blackwall•org>
Cc: netdev@vger•kernel.org, tobias@waldekranz•com, kuba@kernel•org,
davem@davemloft•net, bridge@lists•linux.dev, pabeni@redhat•com,
edumazet@google•com, horms@kernel•org, petrm@nvidia•com
Subject: Re: [PATCH net v2 2/2] net: bridge: fix MST static key usage
Date: Wed, 5 Nov 2025 19:04:33 +0200 [thread overview]
Message-ID: <aQuDobziTNYqOxB4@shredder> (raw)
In-Reply-To: <20251105111919.1499702-3-razor@blackwall.org>
On Wed, Nov 05, 2025 at 01:19:19PM +0200, Nikolay Aleksandrov wrote:
> As Ido pointed out, the static key usage in MST is buggy and should use
> inc/dec instead of enable/disable because we can have multiple bridges
> with MST enabled which means a single bridge can disable MST for all.
> Use static_branch_inc/dec to avoid that. When destroying a bridge decrement
> the key if MST was enabled.
>
> Fixes: ec7328b59176 ("net: bridge: mst: Multiple Spanning Tree (MST) mode")
> Reported-by: Ido Schimmel <idosch@nvidia•com>
> Closes: https://lore.kernel.org/netdev/20251104120313.1306566-1-razor@blackwall.org/T/#m6888d87658f94ed1725433940f4f4ebb00b5a68b
> Signed-off-by: Nikolay Aleksandrov <razor@blackwall•org>
Reviewed-by: Ido Schimmel <idosch@nvidia•com>
next prev parent reply other threads:[~2025-11-05 17:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-05 11:19 [PATCH net v2 0/2] net: bridge: fix two MST bugs Nikolay Aleksandrov
2025-11-05 11:19 ` [PATCH net v2 1/2] net: bridge: fix use-after-free due to MST port state bypass Nikolay Aleksandrov
2025-11-05 16:59 ` Ido Schimmel
2025-11-05 11:19 ` [PATCH net v2 2/2] net: bridge: fix MST static key usage Nikolay Aleksandrov
2025-11-05 17:04 ` Ido Schimmel [this message]
2025-11-06 15:40 ` [PATCH net v2 0/2] net: bridge: fix two MST bugs patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aQuDobziTNYqOxB4@shredder \
--to=idosch@nvidia$(echo .)com \
--cc=bridge@lists$(echo .)linux.dev \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=petrm@nvidia$(echo .)com \
--cc=razor@blackwall$(echo .)org \
--cc=tobias@waldekranz$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox