From: Simon Horman <horms@kernel•org>
To: Kai-Heng Feng <kaihengf@nvidia•com>
Cc: irusskikh@marvell•com, Andrew Lunn <andrew+netdev@lunn•ch>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
netdev@vger•kernel.org, linux-kernel@vger•kernel.org
Subject: Re: [PATCH] net: aquantia: Add missing descriptor cache invalidation on ATL2
Date: Mon, 10 Nov 2025 17:48:08 +0000 [thread overview]
Message-ID: <aRIlWAR1Px-OFKEr@horms.kernel.org> (raw)
In-Reply-To: <20251107052052.42126-1-kaihengf@nvidia.com>
On Fri, Nov 07, 2025 at 01:20:48PM +0800, Kai-Heng Feng wrote:
> ATL2 hardware was missing descriptor cache invalidation in hw_stop(),
> causing SMMU translation faults during device shutdown and module removal.
>
> Commit 7a1bb49461b1 ("net: aquantia: fix potential IOMMU fault after
> driver unbind") and commit ed4d81c4b3f2 ("net: aquantia: when cleaning
> hw cache it should be toggled") fixed cache invalidation for ATL B0, but
> ATL2 was left with only interrupt disabling. This allowed hardware to
> write to cached descriptors after DMA memory was unmapped, triggering
> SMMU faults.
>
> Add shared aq_hw_invalidate_descriptor_cache() helper and use it in both
> ATL B0 and ATL2 hw_stop() implementations for consistent behavior.
I think it would be useful to mention how this bug was found.
And what sort of testing has been conducted: compilation only,
exercised on real hardware, ...
As a bug fix I think this should have a Fixes tag denoting
the commit that introduced the problem. In this case, perhaps:
Fixes: e54dcf4bba3e ("net: atlantic: basic A2 init/deinit hw_ops")
The fixes tag should go immediately above your signed-off-by line,
with no blank lines in between.
> Signed-off-by: Kai-Heng Feng <kaihengf@nvidia•com>
And lastly, for reference: as a fix for code present in the net tree, this
should be targeted at that tree, which should be denoted in the Subject
like this:
Subject: [PATCH net] ...
You can see more on process for Networking patches here:
https://docs.kernel.org/process/maintainer-netdev.html
...
prev parent reply other threads:[~2025-11-10 17:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-07 5:20 [PATCH] net: aquantia: Add missing descriptor cache invalidation on ATL2 Kai-Heng Feng
2025-11-10 17:48 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aRIlWAR1Px-OFKEr@horms.kernel.org \
--to=horms@kernel$(echo .)org \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=irusskikh@marvell$(echo .)com \
--cc=kaihengf@nvidia$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox