From: "Russell King (Oracle)" <linux@armlinux•org.uk>
To: Jakub Kicinski <kuba@kernel•org>
Cc: Yao Zi <ziyao@disroot•org>, Andrew Lunn <andrew+netdev@lunn•ch>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Paolo Abeni <pabeni@redhat•com>,
Yanteng Si <si.yanteng@linux•dev>,
Huacai Chen <chenhuacai@kernel•org>,
Philipp Stanner <phasta@kernel•org>,
Tiezhu Yang <yangtiezhu@loongson•cn>,
Qunqin Zhao <zhaoqunqin@loongson•cn>,
Vladimir Oltean <vladimir.oltean@nxp•com>,
Furong Xu <0x1207@gmail•com>,
Kunihiko Hayashi <hayashi.kunihiko@socionext•com>,
Jacob Keller <jacob.e.keller@intel•com>,
netdev@vger•kernel.org, linux-kernel@vger•kernel.org
Subject: Re: [PATCH net-next v4 1/3] net: stmmac: Add generic suspend/resume helper for PCI-based controllers
Date: Wed, 12 Nov 2025 15:15:45 +0000 [thread overview]
Message-ID: <aRSkoTJjVlUC6ZLQ@shell.armlinux.org.uk> (raw)
In-Reply-To: <20251112065720.017c4d07@kernel.org>
On Wed, Nov 12, 2025 at 06:57:20AM -0800, Jakub Kicinski wrote:
> On Tue, 11 Nov 2025 10:07:26 +0000 Yao Zi wrote:
> > +config STMMAC_LIBPCI
> > + tristate "STMMAC PCI helper library"
> > + depends on PCI
> > + default y
> > + help
> > + This selects the PCI bus helpers for the stmmac driver. If you
> > + have a controller with PCI interface, say Y or M here.
>
> I didn't pay enough attention to the discussion on v2, sorry.
> I understand that there's precedent for a library symbol hiding
> real symbols in this driver but it really makes for a poor user
> experience.
>
> The symbol should be hidden, and select'ed by what needs it.
> With the PCI dependency on the real symbol, not here.
>
> The "default y" may draw the attention of the Superior Penguin.
> He may have quite a lot to criticize in this area, so let's
> not risk it..
Okay, should we also convert STMMAC_PLATFORM to behave the same way,
because it's odd to have one bus type acting one way and the other
differently.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2025-11-12 15:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-11 10:07 [PATCH net-next v4 0/3] Unify platform suspend/resume routines for PCI DWMAC glue Yao Zi
2025-11-11 10:07 ` [PATCH net-next v4 1/3] net: stmmac: Add generic suspend/resume helper for PCI-based controllers Yao Zi
2025-11-12 1:22 ` Yanteng Si
2025-11-12 14:57 ` Jakub Kicinski
2025-11-12 15:15 ` Russell King (Oracle) [this message]
2025-11-15 9:37 ` Yao Zi
2025-11-11 10:07 ` [PATCH net-next v4 2/3] net: stmmac: loongson: Use generic PCI suspend/resume routines Yao Zi
2025-11-11 10:23 ` Russell King (Oracle)
2025-11-12 1:23 ` Yanteng Si
2025-11-11 10:11 ` [PATCH net-next v4 3/3] net: stmmac: pci: " Yao Zi
2025-11-11 10:24 ` Russell King (Oracle)
2025-11-12 1:24 ` Yanteng Si
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aRSkoTJjVlUC6ZLQ@shell.armlinux.org.uk \
--to=linux@armlinux$(echo .)org.uk \
--cc=0x1207@gmail$(echo .)com \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=chenhuacai@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=hayashi.kunihiko@socionext$(echo .)com \
--cc=jacob.e.keller@intel$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=phasta@kernel$(echo .)org \
--cc=si.yanteng@linux$(echo .)dev \
--cc=vladimir.oltean@nxp$(echo .)com \
--cc=yangtiezhu@loongson$(echo .)cn \
--cc=zhaoqunqin@loongson$(echo .)cn \
--cc=ziyao@disroot$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox