Subject: Re: [PATCH net-next v4 1/4] net: phy: mscc: Simplify LED mode update using phy_modify()

From: "Russell King (Oracle)" <[email-masked]>
Date: Wed, 12 Nov 2025 17:38:31 +0000

On Wed, Nov 12, 2025 at 01:57:12PM +0000, Prabhakar wrote:
> From: Lad Prabhakar <[email-masked]>
> 
> The vsc85xx_led_cntl_set() function currently performs a manual
> read-modify-write sequence protected by the PHY lock to update the
> LED mode register (MSCC_PHY_LED_MODE_SEL).
> 
> Replace this sequence with a call to phy_modify(), which already
> handles read-modify-write operations with proper locking inside
> the PHY core.
> 
> Signed-off-by: Lad Prabhakar <[email-masked]>
> Reviewed-by: Andrew Lunn <[email-masked]>

Reviewed-by: Russell King (Oracle) <[email-masked]>

Thanks!

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!