Subject: Re: [PATCH] r8169: add support for RTL8127ATF

From: Fabio Baltieri <[email-masked]>
Date: Tue, 18 Nov 2025 22:01:42 +0000

On Tue, Nov 18, 2025 at 10:31:54PM +0100, Michael Zimmermann wrote:
> One thing the out-of-tree driver does, which your patch doesn't do, is
> disabling eee when in fiber mode. I'd suggest something like this:
> @@ -845,7 +860,8 @@ static bool rtl_supports_eee(struct rtl8169_private *tp)
>  {
>         return tp->mac_version >= RTL_GIGA_MAC_VER_34 &&
>                tp->mac_version != RTL_GIGA_MAC_VER_37 &&
> -              tp->mac_version != RTL_GIGA_MAC_VER_39;
> +              tp->mac_version != RTL_GIGA_MAC_VER_39 &&
> +              !tp->fiber_enabled;
>  }

Heya, don't I have exactly that diff in the patch? The second chunk

@@ -842,7 +843,8 @@ static bool rtl_supports_eee(struct rtl8169_private *tp)
 {
 	return tp->mac_version >= RTL_GIGA_MAC_VER_34 &&
 	       tp->mac_version != RTL_GIGA_MAC_VER_37 &&
-	       tp->mac_version != RTL_GIGA_MAC_VER_39;
+	       tp->mac_version != RTL_GIGA_MAC_VER_39 &&
+	       !tp->fiber_mode;
 }