From: "Russell King (Oracle)" <linux@armlinux•org.uk>
To: Inochi Amaoto <inochiama@gmail•com>
Cc: Andrew Lunn <andrew+netdev@lunn•ch>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
Rob Herring <robh@kernel•org>,
Krzysztof Kozlowski <krzk+dt@kernel•org>,
Conor Dooley <conor+dt@kernel•org>, Yixun Lan <dlan@gentoo•org>,
Maxime Coquelin <mcoquelin.stm32@gmail•com>,
Alexandre Torgue <alexandre.torgue@foss•st.com>,
Richard Cochran <richardcochran@gmail•com>,
Paul Walmsley <pjw@kernel•org>,
Palmer Dabbelt <palmer@dabbelt•com>,
Albert Ou <aou@eecs•berkeley.edu>,
Alexandre Ghiti <alex@ghiti•fr>,
Yanteng Si <siyanteng@cqsoftware•com.cn>,
Yao Zi <ziyao@disroot•org>,
Vladimir Oltean <vladimir.oltean@nxp•com>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp•renesas.com>,
Choong Yong Liang <yong.liang.choong@linux•intel.com>,
Maxime Chevallier <maxime.chevallier@bootlin•com>,
Chen-Yu Tsai <wens@kernel•org>,
Shangjuan Wei <weishangjuan@eswincomputing•com>,
Boon Khai Ng <boon.khai.ng@altera•com>,
Quentin Schulz <quentin.schulz@cherry•de>,
Giuseppe Cavallaro <peppe.cavallaro@st•com>,
Jose Abreu <joabreu@synopsys•com>,
netdev@vger•kernel.org, devicetree@vger•kernel.org,
linux-kernel@vger•kernel.org, linux-riscv@lists•infradead.org,
spacemit@lists•linux.dev,
linux-stm32@st-md-mailman•stormreply.com,
linux-arm-kernel@lists•infradead.org,
Longbin Li <looong.bin@gmail•com>
Subject: Re: [PATCH net-next 3/3] net: stmmac: Add glue layer for Spacemit K3 SoC
Date: Tue, 20 Jan 2026 04:56:32 +0000 [thread overview]
Message-ID: <aW8LAFhCRWlMVemz@shell.armlinux.org.uk> (raw)
In-Reply-To: <20260120043609.910302-4-inochiama@gmail.com>
On Tue, Jan 20, 2026 at 12:36:08PM +0800, Inochi Amaoto wrote:
> Adds Spacemit dwmac driver support on the Spacemit K3 SoC.
Some more information would be useful. E.g. describing why you need to
fix the RGMII mode.
> +/* ctrl register bits */
> +#define PHY_INTF_RGMII BIT(3)
> +#define PHY_INTF_MII BIT(4)
> +
> +#define WAKE_IRQ_EN BIT(9)
> +#define PHY_IRQ_EN BIT(12)
> +
> +/* dline register bits */
> +#define RGMII_RX_DLINE_EN BIT(0)
> +#define RGMII_RX_DLINE_STEP GENMASK(5, 4)
> +#define RGMII_RX_DLINE_CODE GENMASK(15, 8)
> +#define RGMII_TX_DLINE_EN BIT(16)
> +#define RGMII_TX_DLINE_STEP GENMASK(21, 20)
> +#define RGMII_TX_DLINE_CODE GENMASK(31, 24)
> +
> +#define MAX_DLINE_DELAY_CODE 0xff
> +
> +struct spacemit_dwmac {
> + struct device *dev;
> + struct clk *tx;
> +};
This structure seems unused.
> +
> +/* Note: the delay step value is at 0.1ps */
> +static const unsigned int k3_delay_step_10x[4] = {
> + 367, 493, 559, 685
> +};
> +
> +static int spacemit_dwmac_set_delay(struct regmap *apmu,
> + unsigned int dline_offset,
> + unsigned int tx_code, unsigned int tx_config,
> + unsigned int rx_code, unsigned int rx_config)
> +{
> + unsigned int mask, val;
> +
> + mask = RGMII_RX_DLINE_STEP | RGMII_TX_DLINE_CODE | RGMII_TX_DLINE_EN |
> + RGMII_TX_DLINE_STEP | RGMII_RX_DLINE_CODE | RGMII_RX_DLINE_EN;
> + val = FIELD_PREP(RGMII_TX_DLINE_CODE, tx_config) |
> + FIELD_PREP(RGMII_TX_DLINE_CODE, tx_code) | RGMII_TX_DLINE_EN |
> + FIELD_PREP(RGMII_TX_DLINE_CODE, rx_config) |
> + FIELD_PREP(RGMII_RX_DLINE_CODE, rx_code) | RGMII_RX_DLINE_EN;
These FIELD_PREP() fields look wrong. Did you mean to use DLINE_CODE
both tx_config and tx_code, and did you mean to use TX_DLINE_CODE for
rx_config ?
> + plat_dat->clk_tx_i = devm_clk_get_enabled(&pdev->dev, "tx");
> + if (IS_ERR(plat_dat->clk_tx_i))
> + return dev_err_probe(&pdev->dev, PTR_ERR(plat_dat->clk_tx_i),
> + "failed to get tx clock\n");
You set plat_dat->clk_tx_i, but you don't point
plat_dat->set_clk_tx_rate at anything, which means the stmmac core
does nothing with this.
Given the last two points, has RGMII mode been tested on this
hardware?
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2026-01-20 4:57 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-20 4:36 [PATCH net-next 0/3] riscv: spacemit: Add ethernet support for K3 Inochi Amaoto
2026-01-20 4:36 ` [PATCH net-next 1/3] dt-bindings: net: Add support for Spacemit K3 dwmac Inochi Amaoto
2026-01-20 10:55 ` Yao Zi
2026-01-20 11:39 ` Inochi Amaoto
2026-01-20 13:48 ` Andrew Lunn
2026-01-20 22:31 ` Inochi Amaoto
2026-01-20 4:36 ` [PATCH net-next 2/3] net: stmmac: platform: Add snps,dwmac-5.40a IP compatible string Inochi Amaoto
2026-01-20 4:36 ` [PATCH net-next 3/3] net: stmmac: Add glue layer for Spacemit K3 SoC Inochi Amaoto
2026-01-20 4:56 ` Russell King (Oracle) [this message]
2026-01-20 5:05 ` Inochi Amaoto
2026-01-21 12:03 ` Russell King (Oracle)
2026-01-21 22:36 ` Inochi Amaoto
2026-01-21 23:56 ` Inochi Amaoto
2026-01-20 11:13 ` Yao Zi
2026-01-20 11:28 ` Russell King (Oracle)
2026-01-20 11:43 ` Inochi Amaoto
2026-01-20 11:32 ` Yixun Lan
2026-01-20 11:41 ` Inochi Amaoto
2026-01-20 13:56 ` Andrew Lunn
2026-01-20 22:36 ` Inochi Amaoto
2026-01-21 1:29 ` Andrew Lunn
2026-01-21 1:37 ` Inochi Amaoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aW8LAFhCRWlMVemz@shell.armlinux.org.uk \
--to=linux@armlinux$(echo .)org.uk \
--cc=alex@ghiti$(echo .)fr \
--cc=alexandre.torgue@foss$(echo .)st.com \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=aou@eecs$(echo .)berkeley.edu \
--cc=boon.khai.ng@altera$(echo .)com \
--cc=conor+dt@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=dlan@gentoo$(echo .)org \
--cc=edumazet@google$(echo .)com \
--cc=inochiama@gmail$(echo .)com \
--cc=joabreu@synopsys$(echo .)com \
--cc=krzk+dt@kernel$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-riscv@lists$(echo .)infradead.org \
--cc=linux-stm32@st-md-mailman$(echo .)stormreply.com \
--cc=looong.bin@gmail$(echo .)com \
--cc=maxime.chevallier@bootlin$(echo .)com \
--cc=mcoquelin.stm32@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=palmer@dabbelt$(echo .)com \
--cc=peppe.cavallaro@st$(echo .)com \
--cc=pjw@kernel$(echo .)org \
--cc=prabhakar.mahadev-lad.rj@bp$(echo .)renesas.com \
--cc=quentin.schulz@cherry$(echo .)de \
--cc=richardcochran@gmail$(echo .)com \
--cc=robh@kernel$(echo .)org \
--cc=siyanteng@cqsoftware$(echo .)com.cn \
--cc=spacemit@lists$(echo .)linux.dev \
--cc=vladimir.oltean@nxp$(echo .)com \
--cc=weishangjuan@eswincomputing$(echo .)com \
--cc=wens@kernel$(echo .)org \
--cc=yong.liang.choong@linux$(echo .)intel.com \
--cc=ziyao@disroot$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox