From: Simon Horman <horms@kernel•org>
To: Slark Xiao <slark_xiao@163•com>
Cc: loic.poulain@oss•qualcomm.com, ryazanov.s.a@gmail•com,
johannes@sipsolutions•net, andrew+netdev@lunn•ch,
davem@davemloft•net, edumazet@google•com, kuba@kernel•org,
pabeni@redhat•com, mani@kernel•org, netdev@vger•kernel.org,
linux-kernel@vger•kernel.org,
Muhammad Nuzaihan <zaihan@unrealasia•net>,
Qiang Yu <quic_qianyu@quicinc•com>,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro•org>,
Johan Hovold <johan@kernel•org>
Subject: Re: [net-next v7 5/8] net: wwan: add NMEA port support
Date: Tue, 20 Jan 2026 12:30:37 +0000 [thread overview]
Message-ID: <aW91bYu1ueczfGTh@horms.kernel.org> (raw)
In-Reply-To: <20260115114625.46991-6-slark_xiao@163.com>
On Thu, Jan 15, 2026 at 07:46:22PM +0800, Slark Xiao wrote:
...
> diff --git a/drivers/net/wwan/wwan_core.c b/drivers/net/wwan/wwan_core.c
...
> +#else
> +static inline int wwan_port_register_gnss(struct wwan_port *port)
> +{
> + return -EOPNOTSUPP;
> +}
> +
> +static inline void wwan_port_unregister_gnss(struct wwan_port *port)
> +{
> + WARN_ON(1); /* This handler cannot be called */
> +}
Please don't use the inline keyword in .c files unless there is a
demonstrable - usually performance - reason to do so. Rather, let the
compiler inline code as it sees fit.
Using the inline keyword in .h is of course fine.
> +#endif
> +
...
next prev parent reply other threads:[~2026-01-20 12:30 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-15 11:46 [net-next v7 0/8] net: wwan: add NMEA port type support Slark Xiao
2026-01-15 11:46 ` [net-next v7 1/8] net: wwan: core: remove unused port_id field Slark Xiao
2026-01-15 11:46 ` [net-next v7 2/8] net: wwan: core: explicit WWAN device reference counting Slark Xiao
2026-01-15 11:46 ` [net-next v7 3/8] net: wwan: core: split port creation and registration Slark Xiao
2026-01-16 2:44 ` [net-next,v7,3/8] " Jakub Kicinski
2026-01-16 3:24 ` Slark Xiao
2026-01-22 2:31 ` Slark Xiao
2026-01-22 12:01 ` Loic Poulain
2026-01-15 11:46 ` [net-next v7 4/8] net: wwan: core: split port unregister and stop Slark Xiao
2026-01-15 11:46 ` [net-next v7 5/8] net: wwan: add NMEA port support Slark Xiao
2026-01-20 12:30 ` Simon Horman [this message]
2026-01-21 2:08 ` Slark Xiao
2026-01-21 14:16 ` Loic Poulain
2026-01-21 16:53 ` Simon Horman
2026-01-15 11:46 ` [net-next v7 6/8] net: wwan: hwsim: refactor to support more port types Slark Xiao
2026-01-15 11:46 ` [net-next v7 7/8] net: wwan: hwsim: support NMEA port emulation Slark Xiao
2026-01-16 2:44 ` [net-next,v7,7/8] " Jakub Kicinski
2026-01-22 3:06 ` Slark Xiao
2026-01-15 11:46 ` [net-next v7 8/8] net: wwan: mhi_wwan_ctrl: Add NMEA channel support Slark Xiao
2026-01-15 20:19 ` Sergey Ryazanov
2026-01-16 2:43 ` [net-next v7 0/8] net: wwan: add NMEA port type support Jakub Kicinski
2026-01-16 3:18 ` Slark Xiao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aW91bYu1ueczfGTh@horms.kernel.org \
--to=horms@kernel$(echo .)org \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=johan@kernel$(echo .)org \
--cc=johannes@sipsolutions$(echo .)net \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=loic.poulain@oss$(echo .)qualcomm.com \
--cc=mani@kernel$(echo .)org \
--cc=manivannan.sadhasivam@linaro$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=quic_qianyu@quicinc$(echo .)com \
--cc=ryazanov.s.a@gmail$(echo .)com \
--cc=slark_xiao@163$(echo .)com \
--cc=zaihan@unrealasia$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox