Subject: Re: [PATCH net-next] net: stmmac: Correct spelling from clk_scr_i to clk_csr_i

From: Yao Zi <[email-masked]>
Date: Sun, 1 Feb 2026 04:43:37 +0000

On Sun, Feb 01, 2026 at 10:36:19AM +0800, Huacai Chen wrote:
> In include/linux/stmmac.h clk_csr_i is spelled as clk_scr_i by mistake,
> so correct it.
> 
> Cc: [email-masked]
> Signed-off-by: Huacai Chen <[email-masked]>
> ---
>  include/linux/stmmac.h | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/include/linux/stmmac.h b/include/linux/stmmac.h
> index f1054b9c2d8a..1ba583ef6e03 100644
> --- a/include/linux/stmmac.h
> +++ b/include/linux/stmmac.h
> @@ -28,14 +28,14 @@
>   * This could also be configured at run time using CPU freq framework. */
>  
>  /* MDC Clock Selection define*/
> -#define	STMMAC_CSR_60_100M	0x0	/* MDC = clk_scr_i/42 */
> -#define	STMMAC_CSR_100_150M	0x1	/* MDC = clk_scr_i/62 */
> -#define	STMMAC_CSR_20_35M	0x2	/* MDC = clk_scr_i/16 */
> -#define	STMMAC_CSR_35_60M	0x3	/* MDC = clk_scr_i/26 */
> -#define	STMMAC_CSR_150_250M	0x4	/* MDC = clk_scr_i/102 */
> -#define	STMMAC_CSR_250_300M	0x5	/* MDC = clk_scr_i/124 */
> -#define	STMMAC_CSR_300_500M	0x6	/* MDC = clk_scr_i/204 */
> -#define	STMMAC_CSR_500_800M	0x7	/* MDC = clk_scr_i/324 */
> +#define	STMMAC_CSR_60_100M	0x0	/* MDC = clk_csr_i/42 */
> +#define	STMMAC_CSR_100_150M	0x1	/* MDC = clk_csr_i/62 */
> +#define	STMMAC_CSR_20_35M	0x2	/* MDC = clk_csr_i/16 */
> +#define	STMMAC_CSR_35_60M	0x3	/* MDC = clk_csr_i/26 */
> +#define	STMMAC_CSR_150_250M	0x4	/* MDC = clk_csr_i/102 */
> +#define	STMMAC_CSR_250_300M	0x5	/* MDC = clk_csr_i/124 */
> +#define	STMMAC_CSR_300_500M	0x6	/* MDC = clk_csr_i/204 */
> +#define	STMMAC_CSR_500_800M	0x7	/* MDC = clk_csr_i/324 */

This seems only a fix to typo in comments, instead of real functionality
bugs, should this be backported?

> It must either fix a real bug that bothers people or just add a device
> ID. To elaborate on the former:
> ...
> - No “trivial” fixes without benefit for users (spelling changes,
>   whitespace cleanups, etc).[1]

>  /* MTL algorithms identifiers */
>  #define MTL_TX_ALGORITHM_WRR	0x0
> -- 
> 2.47.3
> 
> 

Regards,
Yao Zi

[1]: https://docs.kernel.org/6.15/process/stable-kernel-rules.html