Subject: Re: [PATCH net-next v2 3/3] net: stmmac: Add glue layer for Spacemit K3 SoC

From: "Russell King (Oracle)" <[email-masked]>
Date: Wed, 21 Jan 2026 12:05:30 +0000

On Wed, Jan 21, 2026 at 03:13:11PM +0800, Inochi Amaoto wrote:
> +	mask = RGMII_RX_DLINE_STEP | RGMII_TX_DLINE_CODE | RGMII_TX_DLINE_EN |
> +	       RGMII_TX_DLINE_STEP | RGMII_RX_DLINE_CODE | RGMII_RX_DLINE_EN;
> +	val = FIELD_PREP(RGMII_TX_DLINE_STEP, tx_config) |
> +	      FIELD_PREP(RGMII_TX_DLINE_CODE, tx_code) | RGMII_TX_DLINE_EN |
> +	      FIELD_PREP(RGMII_RX_DLINE_STEP, rx_config) |
> +	      FIELD_PREP(RGMII_RX_DLINE_CODE, rx_code) | RGMII_RX_DLINE_EN;

So your reply where you basically stated that all the RGMII.*DLINE.*
constants here should be the same was nonsense. How can we trust your
replies?

> +static int spacemit_dwmac_fix_delay(struct plat_stmmacenet_data *plat_dat,
> +				    struct regmap *apmu,
> +				    unsigned int dline_offset,
> +				    unsigned int tx_delay, unsigned int rx_delay)
> +{
> +	bool mac_rxid = rx_delay != 0;
> +	bool mac_txid = tx_delay != 0;
> +	unsigned int rx_config = 0;
> +	unsigned int tx_config = 0;
> +	int rx_code;
> +	int tx_code;
> +
> +	plat_dat->phy_interface = phy_fix_phy_mode_for_mac_delays(plat_dat->phy_interface,
> +								  mac_txid,
> +								  mac_rxid);

Maybe Andrew can confirm, but this function was to fix up existing
broken DT, and shouldn't be used by brand new drivers.

> +	plat_dat->clk_tx_i = devm_clk_get_enabled(&pdev->dev, "tx");
> +	if (IS_ERR(plat_dat->clk_tx_i))
> +		return dev_err_probe(&pdev->dev, PTR_ERR(plat_dat->clk_tx_i),
> +				     "failed to get tx clock\n");

As stated on the previous series, please don't abuse clk_tx_i for
soemthing that isn't the dwmac's clk_tx_i signal.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!