From: Sabrina Dubroca <sd@queasysnail•net>
To: Ido Schimmel <idosch@nvidia•com>
Cc: David Yang <mmyangfl@gmail•com>,
netdev@vger•kernel.org, Andrew Lunn <andrew+netdev@lunn•ch>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
Nikolay Aleksandrov <razor@blackwall•org>,
Simon Horman <horms@kernel•org>, Mark Bloch <mbloch@nvidia•com>,
Petr Machata <petrm@nvidia•com>,
Stanislav Fomichev <sdf@fomichev•me>,
Carolina Jubran <cjubran@nvidia•com>,
Breno Leitao <leitao@debian•org>,
Shigeru Yoshida <syoshida@redhat•com>,
linux-kernel@vger•kernel.org, bridge@lists•linux.dev
Subject: Re: [PATCH net-next 0/4] u64_stats: Introduce u64_stats_copy()
Date: Thu, 22 Jan 2026 12:02:32 +0100 [thread overview]
Message-ID: <aXIDyPMOvU1fEYDs@krikkit> (raw)
In-Reply-To: <20260122080043.GA547381@shredder>
2026-01-22, 10:00:43 +0200, Ido Schimmel wrote:
> On Wed, Jan 21, 2026 at 06:21:05PM +0100, Sabrina Dubroca wrote:
> > No direct instances using memcpy, but do we need to also full structs
> > copied within a u64_stats_fetch_begin/u64_stats_fetch_retry loop?
>
> My understanding is that we cannot rely on the compiler to perform the
> copy in any particular way. With the suggested helper it is at least
> clear how the copy is done.
Ok, thanks. So those (and a few more similar things in drivers/net)
should also be switched to this new helper.
--
Sabrina
prev parent reply other threads:[~2026-01-22 11:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-20 9:21 [PATCH net-next 0/4] u64_stats: Introduce u64_stats_copy() David Yang
2026-01-20 9:21 ` [PATCH net-next 1/4] " David Yang
2026-01-21 17:23 ` Sabrina Dubroca
2026-01-21 18:22 ` Yangfl
2026-01-22 11:20 ` Sabrina Dubroca
2026-01-22 15:13 ` Yangfl
2026-01-20 9:21 ` [PATCH net-next 2/4] net: bridge: mcast: fix memcpy with u64_stats David Yang
2026-01-20 9:21 ` [PATCH net-next 3/4] macsec: " David Yang
2026-01-20 9:21 ` [PATCH net-next 4/4] vxlan: vnifilter: " David Yang
2026-01-21 11:16 ` [PATCH net-next 0/4] u64_stats: Introduce u64_stats_copy() Ido Schimmel
2026-01-21 17:21 ` Sabrina Dubroca
2026-01-22 8:00 ` Ido Schimmel
2026-01-22 11:02 ` Sabrina Dubroca [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXIDyPMOvU1fEYDs@krikkit \
--to=sd@queasysnail$(echo .)net \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=bridge@lists$(echo .)linux.dev \
--cc=cjubran@nvidia$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=idosch@nvidia$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=leitao@debian$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=mbloch@nvidia$(echo .)com \
--cc=mmyangfl@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=petrm@nvidia$(echo .)com \
--cc=razor@blackwall$(echo .)org \
--cc=sdf@fomichev$(echo .)me \
--cc=syoshida@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox