From: Mike Rapoport <rppt@kernel•org>
To: Byungchul Park <byungchul@sk•com>
Cc: linux-mm@kvack•org, akpm@linux-foundation•org,
netdev@vger•kernel.org, linux-kernel@vger•kernel.org,
kernel_team@skhynix•com, harry.yoo@oracle•com, ast@kernel•org,
daniel@iogearbox•net, davem@davemloft•net, kuba@kernel•org,
hawk@kernel•org, john.fastabend@gmail•com, sdf@fomichev•me,
saeedm@nvidia•com, leon@kernel•org, tariqt@nvidia•com,
mbloch@nvidia•com, andrew+netdev@lunn•ch, edumazet@google•com,
pabeni@redhat•com, david@redhat•com, lorenzo.stoakes@oracle•com,
Liam.Howlett@oracle•com, vbabka@suse•cz, surenb@google•com,
mhocko@suse•com, horms@kernel•org, jackmanb@google•com,
hannes@cmpxchg•org, ziy@nvidia•com, ilias.apalodimas@linaro•org,
willy@infradead•org, brauner@kernel•org, kas@kernel•org,
yuzhao@google•com, usamaarif642@gmail•com,
baolin.wang@linux•alibaba.com, almasrymina@google•com,
toke@redhat•com, asml.silence@gmail•com, bpf@vger•kernel.org,
linux-rdma@vger•kernel.org, sfr@canb•auug.org.au, dw@davidwei•uk,
ap420073@gmail•com, dtatulea@nvidia•com
Subject: Re: [PATCH v4] mm: introduce a new page type for page pool in page type
Date: Wed, 25 Feb 2026 09:19:21 +0200 [thread overview]
Message-ID: <aZ6ieTRCPs3IKWpp@kernel.org> (raw)
In-Reply-To: <20260224051347.19621-1-byungchul@sk.com>
On Tue, Feb 24, 2026 at 02:13:47PM +0900, Byungchul Park wrote:
> Currently, the condition 'page->pp_magic == PP_SIGNATURE' is used to
> determine if a page belongs to a page pool. However, with the planned
> removal of @pp_magic, we should instead leverage the page_type in struct
> page, such as PGTY_netpp, for this purpose.
>
> Introduce and use the page type APIs e.g. PageNetpp(), __SetPageNetpp(),
> and __ClearPageNetpp() instead, and remove the existing APIs accessing
> @pp_magic e.g. page_pool_page_is_pp(), netmem_or_pp_magic(), and
> netmem_clear_pp_magic().
>
> Plus, add @page_type to struct net_iov at the same offset as struct page
> so as to use the page_type APIs for struct net_iov as well. While at it,
> reorder @type and @owner in struct net_iov to avoid a hole and
> increasing the struct size.
>
> This work was inspired by the following link:
>
> https://lore.kernel.org/all/582f41c0-2742-4400-9c81-0d46bf4e8314@gmail.com/
>
> While at it, move the sanity check for page pool to on the free path.
>
> Suggested-by: David Hildenbrand <david@redhat•com>
> Co-developed-by: Pavel Begunkov <asml.silence@gmail•com>
> Signed-off-by: Pavel Begunkov <asml.silence@gmail•com>
> Signed-off-by: Byungchul Park <byungchul@sk•com>
> Acked-by: David Hildenbrand <david@redhat•com>
> Acked-by: Zi Yan <ziy@nvidia•com>
> Acked-by: Vlastimil Babka <vbabka@suse•cz>
> Reviewed-by: Toke Høiland-Jørgensen <toke@redhat•com>
Acked-by: Mike Rapoport (Microsoft) <rppt@kernel•org>
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2026-02-25 7:19 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-24 5:13 [PATCH v4] mm: introduce a new page type for page pool in page type Byungchul Park
2026-02-25 7:19 ` Mike Rapoport [this message]
2026-02-26 18:49 ` Johannes Weiner
2026-03-16 22:29 ` Byungchul Park
2026-03-16 22:31 ` [PATCH v5] " Byungchul Park
2026-03-17 9:20 ` Jesper Dangaard Brouer
2026-03-17 10:03 ` Ilias Apalodimas
2026-03-17 11:06 ` Dragos Tatulea
2026-03-19 23:31 ` Jakub Kicinski
2026-03-18 2:02 ` Byungchul Park
2026-03-20 11:44 ` Jesper Dangaard Brouer
2026-03-23 12:16 ` Ilias Apalodimas
2026-03-19 23:31 ` Jakub Kicinski
2026-05-13 9:00 ` [PATCH v4] " Dragos Tatulea
2026-05-13 9:12 ` Vlastimil Babka (SUSE)
2026-05-13 9:26 ` Pedro Falcato
2026-05-13 9:36 ` David Hildenbrand (Arm)
2026-05-13 12:06 ` Dragos Tatulea
2026-05-13 12:11 ` David Hildenbrand (Arm)
2026-05-14 8:54 ` Byungchul Park
2026-05-14 9:24 ` Dragos Tatulea
2026-05-15 0:01 ` Byungchul Park
2026-05-13 9:34 ` David Hildenbrand (Arm)
2026-05-13 12:18 ` Byungchul Park
2026-05-13 12:29 ` David Hildenbrand (Arm)
2026-05-13 12:39 ` Byungchul Park
2026-05-13 13:02 ` David Hildenbrand (Arm)
2026-05-13 13:26 ` Byungchul Park
2026-05-18 9:33 ` David Hildenbrand (Arm)
2026-05-13 9:42 ` Lorenzo Stoakes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZ6ieTRCPs3IKWpp@kernel.org \
--to=rppt@kernel$(echo .)org \
--cc=Liam.Howlett@oracle$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=almasrymina@google$(echo .)com \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=ap420073@gmail$(echo .)com \
--cc=asml.silence@gmail$(echo .)com \
--cc=ast@kernel$(echo .)org \
--cc=baolin.wang@linux$(echo .)alibaba.com \
--cc=bpf@vger$(echo .)kernel.org \
--cc=brauner@kernel$(echo .)org \
--cc=byungchul@sk$(echo .)com \
--cc=daniel@iogearbox$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=david@redhat$(echo .)com \
--cc=dtatulea@nvidia$(echo .)com \
--cc=dw@davidwei$(echo .)uk \
--cc=edumazet@google$(echo .)com \
--cc=hannes@cmpxchg$(echo .)org \
--cc=harry.yoo@oracle$(echo .)com \
--cc=hawk@kernel$(echo .)org \
--cc=horms@kernel$(echo .)org \
--cc=ilias.apalodimas@linaro$(echo .)org \
--cc=jackmanb@google$(echo .)com \
--cc=john.fastabend@gmail$(echo .)com \
--cc=kas@kernel$(echo .)org \
--cc=kernel_team@skhynix$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=leon@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=linux-rdma@vger$(echo .)kernel.org \
--cc=lorenzo.stoakes@oracle$(echo .)com \
--cc=mbloch@nvidia$(echo .)com \
--cc=mhocko@suse$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=saeedm@nvidia$(echo .)com \
--cc=sdf@fomichev$(echo .)me \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=surenb@google$(echo .)com \
--cc=tariqt@nvidia$(echo .)com \
--cc=toke@redhat$(echo .)com \
--cc=usamaarif642@gmail$(echo .)com \
--cc=vbabka@suse$(echo .)cz \
--cc=willy@infradead$(echo .)org \
--cc=yuzhao@google$(echo .)com \
--cc=ziy@nvidia$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox