From: "Russell King (Oracle)" <linux@armlinux•org.uk>
To: "Théo Lebrun" <theo.lebrun@bootlin•com>
Cc: "Nicolai Buchwitz" <nb@tipi-net•de>,
netdev@vger•kernel.org, andrew+netdev@lunn•ch,
claudiu.beznea@tuxon•dev, davem@davemloft•net,
edumazet@google•com, kuba@kernel•org,
nicolas.ferre@microchip•com, pabeni@redhat•com,
phil@raspberrypi•com,
"Grégory Clement" <gregory.clement@bootlin•com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin•com>
Subject: Re: [PATCH 3/5] net: cadence: macb: implement EEE TX LPI support
Date: Wed, 25 Feb 2026 17:50:12 +0000 [thread overview]
Message-ID: <aZ82VFPu2FDmPpJ0@shell.armlinux.org.uk> (raw)
In-Reply-To: <DGO88446M74S.6C1O0I79IM0E@bootlin.com>
On Wed, Feb 25, 2026 at 06:42:08PM +0100, Théo Lebrun wrote:
> On Wed Feb 25, 2026 at 10:15 AM CET, Nicolai Buchwitz wrote:
> > @@ -2349,6 +2454,8 @@ static netdev_tx_t macb_start_xmit(struct sk_buff *skb, struct net_device *dev)
> > netdev_tx_sent_queue(netdev_get_tx_queue(bp->dev, queue_index),
> > skb->len);
> >
> > + macb_tx_lpi_wake(bp);
>
> Should this be protected by a bp->eee_active condition? It could go
> in macb_tx_lpi_wake(). We avoid a spinlock acquire per xmit for most
> platforms. Probably negligeable though.
It will read the register, find the bit clear, and then return if
EEE is already disabled.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2026-02-25 17:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-25 9:15 [PATCH net-next v3 0/5] net: cadence: macb: add IEEE 802.3az EEE support Nicolai Buchwitz
2026-02-25 9:15 ` [PATCH 1/5] net: cadence: macb: add EEE register definitions and capability flag Nicolai Buchwitz
2026-02-25 17:26 ` Théo Lebrun
2026-02-26 1:49 ` Jakub Kicinski
2026-02-25 9:15 ` [PATCH 2/5] net: cadence: macb: add EEE LPI statistics counters Nicolai Buchwitz
2026-02-25 9:15 ` [PATCH 3/5] net: cadence: macb: implement EEE TX LPI support Nicolai Buchwitz
2026-02-25 17:32 ` Sai Krishna Gajula
2026-02-26 8:01 ` Nicolai Buchwitz
2026-02-25 17:42 ` Théo Lebrun
2026-02-25 17:50 ` Russell King (Oracle) [this message]
2026-02-26 9:52 ` Théo Lebrun
2026-02-26 10:49 ` Nicolai Buchwitz
2026-02-26 13:50 ` Théo Lebrun
2026-02-27 9:00 ` Nicolai Buchwitz
2026-02-27 14:39 ` Théo Lebrun
2026-02-25 9:15 ` [PATCH 4/5] net: cadence: macb: add ethtool EEE support Nicolai Buchwitz
2026-02-25 9:15 ` [PATCH 5/5] net: cadence: macb: enable EEE for Raspberry Pi RP1 Nicolai Buchwitz
2026-02-25 10:56 ` [PATCH net-next v3 0/5] net: cadence: macb: add IEEE 802.3az EEE support Nicolai Buchwitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZ82VFPu2FDmPpJ0@shell.armlinux.org.uk \
--to=linux@armlinux$(echo .)org.uk \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=claudiu.beznea@tuxon$(echo .)dev \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=gregory.clement@bootlin$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=nb@tipi-net$(echo .)de \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nicolas.ferre@microchip$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
--cc=phil@raspberrypi$(echo .)com \
--cc=theo.lebrun@bootlin$(echo .)com \
--cc=thomas.petazzoni@bootlin$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox