Subject: Re: [PATCH net 1/2] amd-xgbe: fix sleep while atomic on suspend/resume

From: Simon Horman <[email-masked]>
Date: Thu, 26 Feb 2026 12:40:56 +0000

On Wed, Feb 25, 2026 at 04:30:00PM +0530, Raju Rangoju wrote:

...

> diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-pci.c b/drivers/net/ethernet/amd/xgbe/xgbe-pci.c

...

> @@ -453,7 +453,7 @@ static const struct pci_device_id xgbe_pci_table[] = {
>  };
>  MODULE_DEVICE_TABLE(pci, xgbe_pci_table);
>  
> -static SIMPLE_DEV_PM_OPS(xgbe_pci_pm_ops, xgbe_pci_suspend, xgbe_pci_resume);
> +DEFINE_SIMPLE_DEV_PM_OPS(xgbe_pci_pm_ops, xgbe_pci_suspend, xgbe_pci_resume);

Sorry for not noticing this before sending my previous email.

Sparse flags that xgbe_pci_pm_ops should (still) be static.

>  
>  static struct pci_driver xgbe_driver = {
>  	.name = XGBE_DRV_NAME,

...