Subject: Re: [RFC PATCH net-next 3/3] failover: use .ndo_update_offloads for failover

From: Hangbin Liu <[email-masked]>
Date: Thu, 26 Feb 2026 12:48:27 +0000

On Thu, Feb 26, 2026 at 11:42:08AM +0000, Hangbin Liu wrote:
> diff --git a/include/net/net_failover.h b/include/net/net_failover.h
> index b12a1c469d1c..f0f038d113a0 100644
> --- a/include/net/net_failover.h
> +++ b/include/net/net_failover.h
> @@ -30,11 +30,4 @@ struct net_failover_info {
>  struct failover *net_failover_create(struct net_device *standby_dev);
>  void net_failover_destroy(struct failover *failover);
>  
> -#define FAILOVER_VLAN_FEATURES	(NETIF_F_HW_CSUM | NETIF_F_SG | \
> -				 NETIF_F_FRAGLIST | NETIF_F_ALL_TSO | \
> -				 NETIF_F_HIGHDMA | NETIF_F_LRO)
> -

Oh, forgot to fix this. Maybe we can use MASTER_UPPER_DEV_VLAN_FEATURES to
replace it?

drivers/net/net_failover.c: In function ‘net_failover_create’:
drivers/net/net_failover.c:687:37: error: ‘FAILOVER_VLAN_FEATURES’ undeclared (first use in this function)
  687 |         failover_dev->hw_features = FAILOVER_VLAN_FEATURES |
      |                                     ^~~~~~~~~~~~~~~~~~~~~~

Thanks
Hangbin

> -#define FAILOVER_ENC_FEATURES	(NETIF_F_HW_CSUM | NETIF_F_SG | \
> -				 NETIF_F_RXCSUM | NETIF_F_ALL_TSO)
> -
>  #endif /* _NET_FAILOVER_H */
> -- 
> 2.50.1
>