From: Simon Horman <horms@kernel•org>
To: Chintan Vankar <c-vankar@ti•com>
Cc: Mugunthan V N <mugunthanvnm@ti•com>,
Richard Cochran <richardcochran@gmail•com>,
Stefan Wiehler <stefan.wiehler@nokia•com>,
Thomas Gleixner <tglx@kernel•org>, Ingo Molnar <mingo@kernel•org>,
Vishnu Singh <v-singh1@ti•com>,
Vignesh Raghavendra <vigneshr@ti•com>,
Matthias Schiffer <matthias.schiffer@ew•tq-group.com>,
Vadim Fedorenko <vadim.fedorenko@linux•dev>,
Nishanth Menon <nm@ti•com>, Michael Walle <mwalle@kernel•org>,
Roger Quadros <rogerq@kernel•org>,
Siddharth Vadapalli <s-vadapalli@ti•com>,
Paolo Abeni <pabeni@redhat•com>, Jakub Kicinski <kuba@kernel•org>,
Eric Dumazet <edumazet@google•com>,
"David S. Miller" <davem@davemloft•net>,
Andrew Lunn <andrew+netdev@lunn•ch>,
linux-omap@vger•kernel.org, linux-kernel@vger•kernel.org,
netdev@vger•kernel.org
Subject: Re: [PATCH net v2] net: ethernet: ti: am65-cpsw-nuss/cpsw-ale: Fix multicast entry handling in ALE table
Date: Thu, 26 Feb 2026 19:54:14 +0000 [thread overview]
Message-ID: <aaCk5pDO-xGf4W4A@horms.kernel.org> (raw)
In-Reply-To: <20260224181359.2055322-1-c-vankar@ti.com>
On Tue, Feb 24, 2026 at 11:43:59PM +0530, Chintan Vankar wrote:
> In the current implementation, flushing multicast entries in MAC mode
> incorrectly deletes entries for all ports instead of only the target port,
> disrupting multicast traffic on other ports. The cause is adding multicast
> entries by setting only host port bit, and not setting the MAC port bits.
>
> Fix this by setting the MAC port's bit in the port mask while adding the
> multicast entry. Also fix the flush logic to preserve the host port bit
> during removal of MAC port and free ALE entries when mask contains only
> host port.
>
> Fixes: 5c50a856d550 ("drivers: net: ethernet: cpsw: add multicast address to ALE table")
> Signed-off-by: Chintan Vankar <c-vankar@ti•com>
> ---
>
> This patch is based on commit 'd4f687fbbce4' of origin/main branch of
> Linux net repo.
>
> Link to v1:
> https://lore.kernel.org/r/20260205070951.3170631-1-c-vankar@ti.com/
>
> Changes from v1 to v2:
> - Squashed two patches into one as a fix of the older implementation.
> - Added "Fixes" tag in the commit.
Reviewed-by: Simon Horman <horms@kernel•org>
...
next prev parent reply other threads:[~2026-02-26 19:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-24 18:13 [PATCH net v2] net: ethernet: ti: am65-cpsw-nuss/cpsw-ale: Fix multicast entry handling in ALE table Chintan Vankar
2026-02-26 19:54 ` Simon Horman [this message]
2026-02-27 3:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aaCk5pDO-xGf4W4A@horms.kernel.org \
--to=horms@kernel$(echo .)org \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=c-vankar@ti$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-omap@vger$(echo .)kernel.org \
--cc=matthias.schiffer@ew$(echo .)tq-group.com \
--cc=mingo@kernel$(echo .)org \
--cc=mugunthanvnm@ti$(echo .)com \
--cc=mwalle@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nm@ti$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
--cc=richardcochran@gmail$(echo .)com \
--cc=rogerq@kernel$(echo .)org \
--cc=s-vadapalli@ti$(echo .)com \
--cc=stefan.wiehler@nokia$(echo .)com \
--cc=tglx@kernel$(echo .)org \
--cc=v-singh1@ti$(echo .)com \
--cc=vadim.fedorenko@linux$(echo .)dev \
--cc=vigneshr@ti$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox