From: Simon Horman <horms@kernel•org>
To: Conor Dooley <conor@kernel•org>
Cc: netdev@vger•kernel.org,
"Conor Dooley" <conor.dooley@microchip•com>,
Valentina.FernandezAlanis@microchip•com,
"Andrew Lunn" <andrew+netdev@lunn•ch>,
"David S. Miller" <davem@davemloft•net>,
"Eric Dumazet" <edumazet@google•com>,
"Jakub Kicinski" <kuba@kernel•org>,
"Paolo Abeni" <pabeni@redhat•com>,
"Rob Herring" <robh@kernel•org>,
"Krzysztof Kozlowski" <krzk+dt@kernel•org>,
"Conor Dooley" <conor+dt@kernel•org>,
"Daire McNamara" <daire.mcnamara@microchip•com>,
"Paul Walmsley" <pjw@kernel•org>,
"Palmer Dabbelt" <palmer@dabbelt•com>,
"Albert Ou" <aou@eecs•berkeley.edu>,
"Alexandre Ghiti" <alex@ghiti•fr>,
"Nicolas Ferre" <nicolas.ferre@microchip•com>,
"Claudiu Beznea" <claudiu.beznea@tuxon•dev>,
"Richard Cochran" <richardcochran@gmail•com>,
"Samuel Holland" <samuel.holland@sifive•com>,
devicetree@vger•kernel.org, linux-kernel@vger•kernel.org,
linux-riscv@lists•infradead.org,
"Neil Armstrong" <narmstrong@baylibre•com>,
"Dave Stevenson" <dave.stevenson@raspberrypi•com>,
"Sean Anderson" <sean.anderson@linux•dev>,
"Vineeth Karumanchi" <vineeth.karumanchi@amd•com>,
"Abin Joseph" <abin.joseph@amd•com>,
"Théo Lebrun" <theo.lebrun@bootlin•com>
Subject: Re: [PATCH net-next v2 5/8] net: macb: timer adjust mode is not supported
Date: Sun, 1 Mar 2026 18:12:33 +0000 [thread overview]
Message-ID: <aaSBkVkhNTbQHkmI@horms.kernel.org> (raw)
In-Reply-To: <20260226-dollop-maturing-9e3c83192ee5@spud>
On Thu, Feb 26, 2026 at 11:03:20AM +0000, Conor Dooley wrote:
> From: Conor Dooley <conor.dooley@microchip•com>
>
> The ptp portion of this driver controls the tsu's timer using the
> controls for "increment mode", which is not compatible with the hardware
> trying to control it via the gem_tsu_inc_ctrl and gem_tsu_ms inputs in
> "timer adjust mode". Abort probe if the property signalling that the
> relevant signals have been wired up is present.
>
> Signed-off-by: Conor Dooley <conor.dooley@microchip•com>
> ---
> drivers/net/ethernet/cadence/macb_main.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
> index ddbb0c327b303..fa55e6e7036f2 100644
> --- a/drivers/net/ethernet/cadence/macb_main.c
> +++ b/drivers/net/ethernet/cadence/macb_main.c
> @@ -5535,6 +5535,12 @@ static int macb_probe(struct platform_device *pdev)
>
> bp->usrio = macb_config->usrio;
>
> + if (of_property_read_bool(bp->pdev->dev.of_node, "cdns,timer-adjust") &&
> + IS_ENABLED(CONFIG_MACB_USE_HWSTAMP)) {
> + dev_err(&pdev->dev, "Timer adjust mode is not supported\n");
Hi Conor,
Assuming this is an error condition I think that err should
be set to an negative error value here. Else the function will return 0.
Flagged by Smatch.
> + goto err_out_free_netdev;
> + }
> +
> /* By default we set to partial store and forward mode for zynqmp.
> * Disable if not set in devicetree.
> */
> --
> 2.51.0
>
>
next prev parent reply other threads:[~2026-03-01 18:12 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-26 11:03 [PATCH net-next v2 0/8] macb usrio/tsu patches Conor Dooley
2026-02-26 11:03 ` [PATCH net-next v2 1/8] riscv: dts: microchip: add tsu clock to macb on mpfs Conor Dooley
2026-02-26 11:09 ` Conor Dooley
2026-02-26 11:03 ` [PATCH net-next v2 2/8] net: macb: rename macb_default_usrio to at91_default_usrio as not all platforms have mii mode control in usrio Conor Dooley
2026-02-28 23:26 ` [net-next,v2,2/8] " Jakub Kicinski
2026-03-01 0:06 ` Conor Dooley
2026-03-03 17:35 ` Ryan Wanner
2026-03-03 18:01 ` Conor Dooley
2026-03-03 22:04 ` Ryan Wanner
2026-03-03 22:44 ` Conor Dooley
2026-03-04 16:13 ` Ryan Wanner
2026-03-04 18:52 ` Conor Dooley
2026-03-05 21:04 ` Conor Dooley
2026-02-26 11:03 ` [PATCH net-next v2 3/8] net: macb: np4 doesn't need a usrio pointer Conor Dooley
2026-02-26 11:03 ` [PATCH net-next v2 4/8] dt-bindings: net: macb: add property indicating timer adjust mode Conor Dooley
2026-02-26 11:03 ` [PATCH net-next v2 5/8] net: macb: timer adjust mode is not supported Conor Dooley
2026-03-01 18:12 ` Simon Horman [this message]
2026-02-26 11:03 ` [PATCH net-next v2 6/8] net: macb: add mpfs specific usrio configuration Conor Dooley
2026-02-26 11:03 ` [PATCH net-next v2 7/8] net: macb: warn on pclk use as a tsu_clk fallback Conor Dooley
2026-02-26 11:03 ` [PATCH net-next v2 8/8] net: macb: clean up tsu clk rate acquisition Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aaSBkVkhNTbQHkmI@horms.kernel.org \
--to=horms@kernel$(echo .)org \
--cc=Valentina.FernandezAlanis@microchip$(echo .)com \
--cc=abin.joseph@amd$(echo .)com \
--cc=alex@ghiti$(echo .)fr \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=aou@eecs$(echo .)berkeley.edu \
--cc=claudiu.beznea@tuxon$(echo .)dev \
--cc=conor+dt@kernel$(echo .)org \
--cc=conor.dooley@microchip$(echo .)com \
--cc=conor@kernel$(echo .)org \
--cc=daire.mcnamara@microchip$(echo .)com \
--cc=dave.stevenson@raspberrypi$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=edumazet@google$(echo .)com \
--cc=krzk+dt@kernel$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-riscv@lists$(echo .)infradead.org \
--cc=narmstrong@baylibre$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nicolas.ferre@microchip$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
--cc=palmer@dabbelt$(echo .)com \
--cc=pjw@kernel$(echo .)org \
--cc=richardcochran@gmail$(echo .)com \
--cc=robh@kernel$(echo .)org \
--cc=samuel.holland@sifive$(echo .)com \
--cc=sean.anderson@linux$(echo .)dev \
--cc=theo.lebrun@bootlin$(echo .)com \
--cc=vineeth.karumanchi@amd$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox