Subject: Re: [PATCH net-next 2/2] net: sfp: manage receiver and transmitter regulators

From: "Russell King (Oracle)" <[email-masked]>
Date: Tue, 3 Mar 2026 15:12:56 +0000

On Tue, Mar 03, 2026 at 03:40:54PM +0100, Romain Gantois wrote:
> Hello Mark,
> 
> On Tuesday, 3 March 2026 15:22:40 CET Mark Brown wrote:
> > On Tue, Mar 03, 2026 at 02:54:27PM +0100, Romain Gantois wrote:
> > > If phandles to receiver and/or transmitter regulators for an SFP device
> > > are
> > > found, enable them at probe time.
> > 
> > The driver should unconditionally request whatever power the device
> > needs.
> 
> Ok, I'll use devm_regulator_get_enable() instead then.

What Mark is suggesting will break existing users. So, I'm afraid we
can't proceed with this proposal. Sorry.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!