From: Christoph Hellwig <hch@infradead•org>
To: Jeff Layton <jlayton@kernel•org>
Cc: "Alexander Viro" <viro@zeniv•linux.org.uk>,
"Christian Brauner" <brauner@kernel•org>,
"Jan Kara" <jack@suse•cz>, "Steven Rostedt" <rostedt@goodmis•org>,
"Masami Hiramatsu" <mhiramat@kernel•org>,
"Mathieu Desnoyers" <mathieu.desnoyers@efficios•com>,
"Dan Williams" <dan.j.williams@intel•com>,
"Eric Biggers" <ebiggers@kernel•org>,
"Theodore Y. Ts'o" <tytso@mit•edu>,
"Muchun Song" <muchun.song@linux•dev>,
"Oscar Salvador" <osalvador@suse•de>,
"David Hildenbrand" <david@kernel•org>,
"David Howells" <dhowells@redhat•com>,
"Paulo Alcantara" <pc@manguebit•org>,
"Andreas Dilger" <adilger.kernel@dilger•ca>,
"Jan Kara" <jack@suse•com>, "Jaegeuk Kim" <jaegeuk@kernel•org>,
"Chao Yu" <chao@kernel•org>,
"Trond Myklebust" <trondmy@kernel•org>,
"Anna Schumaker" <anna@kernel•org>,
"Chuck Lever" <chuck.lever@oracle•com>,
NeilBrown <neil@brown•name>,
"Olga Kornievskaia" <okorniev@redhat•com>,
"Dai Ngo" <Dai.Ngo@oracle•com>, "Tom Talpey" <tom@talpey•com>,
"Steve French" <sfrench@samba•org>,
"Ronnie Sahlberg" <ronniesahlberg@gmail•com>,
"Shyam Prasad N" <sprasad@microsoft•com>,
"Bharath SM" <bharathsm@microsoft•com>,
"Alexander Aring" <alex.aring@gmail•com>,
"Ryusuke Konishi" <konishi.ryusuke@gmail•com>,
"Viacheslav Dubeyko" <slava@dubeyko•com>,
"Eric Van Hensbergen" <ericvh@kernel•org>,
"Latchesar Ionkov" <lucho@ionkov•net>,
"Dominique Martinet" <asmadeus@codewreck•org>,
"Christian Schoenebeck" <linux_oss@crudebyte•com>,
"David Sterba" <dsterba@suse•com>,
"Marc Dionne" <marc.dionne@auristor•com>,
"Ian Kent" <raven@themaw•net>,
"Luis de Bethencourt" <luisbg@kernel•org>,
"Salah Triki" <salah.triki@gmail•com>,
"Tigran A. Aivazian" <aivazian.tigran@gmail•com>,
"Ilya Dryomov" <idryomov@gmail•com>,
"Alex Markuze" <amarkuze@redhat•com>,
"Jan Harkes" <jaharkes@cs•cmu.edu>,
coda@cs•cmu.edu, "Nicolas Pitre" <nico@fluxnic•net>,
"Tyler Hicks" <code@tyhicks•com>,
"Amir Goldstein" <amir73il@gmail•com>,
"Christoph Hellwig" <hch@infradead•org>,
"John Paul Adrian Glaubitz" <glaubitz@physik•fu-berlin.de>,
"Yangtao Li" <frank.li@vivo•com>,
"Mikulas Patocka" <mikulas@artax•karlin.mff.cuni.cz>,
"David Woodhouse" <dwmw2@infradead•org>,
"Richard Weinberger" <richard@nod•at>,
"Dave Kleikamp" <shaggy@kernel•org>,
"Konstantin Komarov" <almaz.alexandrovich@paragon-software•com>,
"Mark Fasheh" <mark@fasheh•com>,
"Joel Becker" <jlbec@evilplan•org>,
"Joseph Qi" <joseph.qi@linux•alibaba.com>,
"Mike Marshall" <hubcap@omnibond•com>,
"Martin Brandenburg" <martin@omnibond•com>,
"Miklos Szeredi" <miklos@szeredi•hu>,
"Anders Larsen" <al@alarsen•net>,
"Zhihao Cheng" <chengzhihao1@huawei•com>,
"Damien Le Moal" <dlemoal@kernel•org>,
"Naohiro Aota" <naohiro.aota@wdc•com>,
"Johannes Thumshirn" <jth@kernel•org>,
"John Johansen" <john.johansen@canonical•com>,
"Paul Moore" <paul@paul-moore•com>,
"James Morris" <jmorris@namei•org>,
"Serge E. Hallyn" <serge@hallyn•com>,
"Mimi Zohar" <zohar@linux•ibm.com>,
"Roberto Sassu" <roberto.sassu@huawei•com>,
"Dmitry Kasatkin" <dmitry.kasatkin@gmail•com>,
"Eric Snowberg" <eric.snowberg@oracle•com>,
"Fan Wu" <wufan@kernel•org>,
"Stephen Smalley" <stephen.smalley.work@gmail•com>,
"Ondrej Mosnacek" <omosnace@redhat•com>,
"Casey Schaufler" <casey@schaufler-ca•com>,
"Alex Deucher" <alexander.deucher@amd•com>,
"Christian König" <christian.koenig@amd•com>,
"David Airlie" <airlied@gmail•com>,
"Simona Vetter" <simona@ffwll•ch>,
"Sumit Semwal" <sumit.semwal@linaro•org>,
"Eric Dumazet" <edumazet@google•com>,
"Kuniyuki Iwashima" <kuniyu@google•com>,
"Paolo Abeni" <pabeni@redhat•com>,
"Willem de Bruijn" <willemb@google•com>,
"David S. Miller" <davem@davemloft•net>,
"Jakub Kicinski" <kuba@kernel•org>,
"Simon Horman" <horms@kernel•org>,
"Oleg Nesterov" <oleg@redhat•com>,
"Peter Zijlstra" <peterz@infradead•org>,
"Ingo Molnar" <mingo@redhat•com>,
"Arnaldo Carvalho de Melo" <acme@kernel•org>,
"Namhyung Kim" <namhyung@kernel•org>,
"Mark Rutland" <mark.rutland@arm•com>,
"Alexander Shishkin" <alexander.shishkin@linux•intel.com>,
"Jiri Olsa" <jolsa@kernel•org>, "Ian Rogers" <irogers@google•com>,
"Adrian Hunter" <adrian.hunter@intel•com>,
"James Clark" <james.clark@linaro•org>,
"Darrick J. Wong" <djwong@kernel•org>,
"Martin Schiller" <ms@dev•tdt.de>,
"Eric Paris" <eparis@redhat•com>,
"Joerg Reuter" <jreuter@yaina•de>,
"Marcel Holtmann" <marcel@holtmann•org>,
"Johan Hedberg" <johan.hedberg@gmail•com>,
"Luiz Augusto von Dentz" <luiz.dentz@gmail•com>,
"Oliver Hartkopp" <socketcan@hartkopp•net>,
"Marc Kleine-Budde" <mkl@pengutronix•de>,
"David Ahern" <dsahern@kernel•org>,
"Neal Cardwell" <ncardwell@google•com>,
"Steffen Klassert" <steffen.klassert@secunet•com>,
"Herbert Xu" <herbert@gondor•apana.org.au>,
"Remi Denis-Courmont" <courmisch@gmail•com>,
"Marcelo Ricardo Leitner" <marcelo.leitner@gmail•com>,
"Xin Long" <lucien.xin@gmail•com>,
"Magnus Karlsson" <magnus.karlsson@intel•com>,
"Maciej Fijalkowski" <maciej.fijalkowski@intel•com>,
"Stanislav Fomichev" <sdf@fomichev•me>,
"Alexei Starovoitov" <ast@kernel•org>,
"Daniel Borkmann" <daniel@iogearbox•net>,
"Jesper Dangaard Brouer" <hawk@kernel•org>,
"John Fastabend" <john.fastabend@gmail•com>,
linux-fsdevel@vger•kernel.org, linux-kernel@vger•kernel.org,
linux-trace-kernel@vger•kernel.org, nvdimm@lists•linux.dev,
fsverity@lists•linux.dev, linux-mm@kvack•org,
netfs@lists•linux.dev, linux-ext4@vger•kernel.org,
linux-f2fs-devel@lists•sourceforge.net,
linux-nfs@vger•kernel.org, linux-cifs@vger•kernel.org,
samba-technical@lists•samba.org, linux-nilfs@vger•kernel.org,
v9fs@lists•linux.dev, linux-afs@lists•infradead.org,
autofs@vger•kernel.org, ceph-devel@vger•kernel.org,
codalist@coda•cs.cmu.edu, ecryptfs@vger•kernel.org,
linux-mtd@lists•infradead.org,
jfs-discussion@lists•sourceforge.net, ntfs3@lists•linux.dev,
ocfs2-devel@lists•linux.dev, devel@lists•orangefs.org,
linux-unionfs@vger•kernel.org, apparmor@lists•ubuntu.com,
linux-security-module@vger•kernel.org,
linux-integrity@vger•kernel.org, selinux@vger•kernel.org,
amd-gfx@lists•freedesktop.org, dri-devel@lists•freedesktop.org,
linux-media@vger•kernel.org, linaro-mm-sig@lists•linaro.org,
netdev@vger•kernel.org, linux-perf-users@vger•kernel.org,
linux-fscrypt@vger•kernel.org, linux-xfs@vger•kernel.org,
linux-hams@vger•kernel.org, linux-x25@vger•kernel.org,
audit@vger•kernel.org, linux-bluetooth@vger•kernel.org,
linux-can@vger•kernel.org, linux-sctp@vger•kernel.org,
bpf@vger•kernel.org
Subject: Re: [PATCH v3 01/12] vfs: widen inode hash/lookup functions to u64
Date: Thu, 5 Mar 2026 06:24:22 -0800 [thread overview]
Message-ID: <aamSFgXhrORAJLBC@infradead.org> (raw)
In-Reply-To: <20260304-iino-u64-v3-1-2257ad83d372@kernel.org>
> extern struct inode *ilookup5_nowait(struct super_block *sb,
> - unsigned long hashval, int (*test)(struct inode *, void *),
> + u64 hashval, int (*test)(struct inode *, void *),
> void *data, bool *isnew);
> -extern struct inode *ilookup5(struct super_block *sb, unsigned long hashval,
> +extern struct inode *ilookup5(struct super_block *sb, u64 hashval,
> int (*test)(struct inode *, void *), void *data);
...
Can you please drop all these pointless externs while you're at it?
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@lst•de>
next prev parent reply other threads:[~2026-03-05 14:25 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-04 15:32 [PATCH v3 00/12] vfs: change inode->i_ino from unsigned long to u64 Jeff Layton
2026-03-04 15:32 ` [PATCH v3 01/12] vfs: widen inode hash/lookup functions " Jeff Layton
2026-03-05 14:24 ` Christoph Hellwig [this message]
2026-03-06 12:03 ` Jeff Layton
2026-03-06 13:28 ` Christian Brauner
2026-03-04 15:32 ` [PATCH v3 02/12] audit: widen ino fields " Jeff Layton
2026-03-06 3:09 ` Paul Moore
2026-03-04 15:32 ` [PATCH v3 03/12] net: change sock.sk_ino and sock_i_ino() " Jeff Layton
2026-03-04 15:32 ` [PATCH v3 04/12] vfs: widen trace event i_ino fields " Jeff Layton
2026-03-05 9:43 ` Jan Kara
2026-03-04 15:32 ` [PATCH v3 05/12] cachefiles: " Jeff Layton
2026-03-04 15:32 ` [PATCH v3 06/12] ext2: " Jeff Layton
2026-03-05 9:44 ` Jan Kara
2026-03-04 15:32 ` [PATCH v3 07/12] hugetlbfs: " Jeff Layton
2026-03-04 15:32 ` [PATCH v3 08/12] zonefs: " Jeff Layton
2026-03-04 21:41 ` Damien Le Moal
2026-03-04 15:32 ` [PATCH v3 09/12] ext4: " Jeff Layton
2026-03-04 15:32 ` [PATCH v3 10/12] f2fs: " Jeff Layton
2026-03-04 15:32 ` [PATCH v3 11/12] nilfs2: " Jeff Layton
2026-03-04 15:32 ` [PATCH v3 12/12] treewide: change inode->i_ino from unsigned long " Jeff Layton
2026-03-04 15:49 ` Chuck Lever
2026-03-04 21:41 ` Damien Le Moal
2026-03-05 9:57 ` Jan Kara
2026-03-05 14:25 ` Christoph Hellwig
2026-03-06 9:09 ` [PATCH v3 00/12] vfs: " Christian Brauner
2026-03-09 17:47 ` Mimi Zohar
2026-03-09 17:59 ` Jeff Layton
2026-03-09 19:00 ` Mimi Zohar
2026-03-09 19:33 ` Jeff Layton
2026-03-09 20:11 ` Mimi Zohar
2026-03-09 20:50 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aamSFgXhrORAJLBC@infradead.org \
--to=hch@infradead$(echo .)org \
--cc=Dai.Ngo@oracle$(echo .)com \
--cc=acme@kernel$(echo .)org \
--cc=adilger.kernel@dilger$(echo .)ca \
--cc=adrian.hunter@intel$(echo .)com \
--cc=airlied@gmail$(echo .)com \
--cc=aivazian.tigran@gmail$(echo .)com \
--cc=al@alarsen$(echo .)net \
--cc=alex.aring@gmail$(echo .)com \
--cc=alexander.deucher@amd$(echo .)com \
--cc=alexander.shishkin@linux$(echo .)intel.com \
--cc=almaz.alexandrovich@paragon-software$(echo .)com \
--cc=amarkuze@redhat$(echo .)com \
--cc=amd-gfx@lists$(echo .)freedesktop.org \
--cc=amir73il@gmail$(echo .)com \
--cc=anna@kernel$(echo .)org \
--cc=apparmor@lists$(echo .)ubuntu.com \
--cc=asmadeus@codewreck$(echo .)org \
--cc=ast@kernel$(echo .)org \
--cc=audit@vger$(echo .)kernel.org \
--cc=autofs@vger$(echo .)kernel.org \
--cc=bharathsm@microsoft$(echo .)com \
--cc=bpf@vger$(echo .)kernel.org \
--cc=brauner@kernel$(echo .)org \
--cc=casey@schaufler-ca$(echo .)com \
--cc=ceph-devel@vger$(echo .)kernel.org \
--cc=chao@kernel$(echo .)org \
--cc=chengzhihao1@huawei$(echo .)com \
--cc=christian.koenig@amd$(echo .)com \
--cc=chuck.lever@oracle$(echo .)com \
--cc=coda@cs$(echo .)cmu.edu \
--cc=codalist@coda$(echo .)cs.cmu.edu \
--cc=code@tyhicks$(echo .)com \
--cc=courmisch@gmail$(echo .)com \
--cc=dan.j.williams@intel$(echo .)com \
--cc=daniel@iogearbox$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=david@kernel$(echo .)org \
--cc=devel@lists$(echo .)orangefs.org \
--cc=dhowells@redhat$(echo .)com \
--cc=djwong@kernel$(echo .)org \
--cc=dlemoal@kernel$(echo .)org \
--cc=dmitry.kasatkin@gmail$(echo .)com \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=dsahern@kernel$(echo .)org \
--cc=dsterba@suse$(echo .)com \
--cc=dwmw2@infradead$(echo .)org \
--cc=ebiggers@kernel$(echo .)org \
--cc=ecryptfs@vger$(echo .)kernel.org \
--cc=edumazet@google$(echo .)com \
--cc=eparis@redhat$(echo .)com \
--cc=eric.snowberg@oracle$(echo .)com \
--cc=ericvh@kernel$(echo .)org \
--cc=frank.li@vivo$(echo .)com \
--cc=fsverity@lists$(echo .)linux.dev \
--cc=glaubitz@physik$(echo .)fu-berlin.de \
--cc=hawk@kernel$(echo .)org \
--cc=herbert@gondor$(echo .)apana.org.au \
--cc=horms@kernel$(echo .)org \
--cc=hubcap@omnibond$(echo .)com \
--cc=idryomov@gmail$(echo .)com \
--cc=irogers@google$(echo .)com \
--cc=jack@suse$(echo .)com \
--cc=jack@suse$(echo .)cz \
--cc=jaegeuk@kernel$(echo .)org \
--cc=jaharkes@cs$(echo .)cmu.edu \
--cc=james.clark@linaro$(echo .)org \
--cc=jfs-discussion@lists$(echo .)sourceforge.net \
--cc=jlayton@kernel$(echo .)org \
--cc=jlbec@evilplan$(echo .)org \
--cc=jmorris@namei$(echo .)org \
--cc=johan.hedberg@gmail$(echo .)com \
--cc=john.fastabend@gmail$(echo .)com \
--cc=john.johansen@canonical$(echo .)com \
--cc=jolsa@kernel$(echo .)org \
--cc=joseph.qi@linux$(echo .)alibaba.com \
--cc=jreuter@yaina$(echo .)de \
--cc=jth@kernel$(echo .)org \
--cc=konishi.ryusuke@gmail$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=kuniyu@google$(echo .)com \
--cc=linaro-mm-sig@lists$(echo .)linaro.org \
--cc=linux-afs@lists$(echo .)infradead.org \
--cc=linux-bluetooth@vger$(echo .)kernel.org \
--cc=linux-can@vger$(echo .)kernel.org \
--cc=linux-cifs@vger$(echo .)kernel.org \
--cc=linux-ext4@vger$(echo .)kernel.org \
--cc=linux-f2fs-devel@lists$(echo .)sourceforge.net \
--cc=linux-fscrypt@vger$(echo .)kernel.org \
--cc=linux-fsdevel@vger$(echo .)kernel.org \
--cc=linux-hams@vger$(echo .)kernel.org \
--cc=linux-integrity@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-media@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=linux-mtd@lists$(echo .)infradead.org \
--cc=linux-nfs@vger$(echo .)kernel.org \
--cc=linux-nilfs@vger$(echo .)kernel.org \
--cc=linux-perf-users@vger$(echo .)kernel.org \
--cc=linux-sctp@vger$(echo .)kernel.org \
--cc=linux-security-module@vger$(echo .)kernel.org \
--cc=linux-trace-kernel@vger$(echo .)kernel.org \
--cc=linux-unionfs@vger$(echo .)kernel.org \
--cc=linux-x25@vger$(echo .)kernel.org \
--cc=linux-xfs@vger$(echo .)kernel.org \
--cc=linux_oss@crudebyte$(echo .)com \
--cc=lucho@ionkov$(echo .)net \
--cc=lucien.xin@gmail$(echo .)com \
--cc=luisbg@kernel$(echo .)org \
--cc=luiz.dentz@gmail$(echo .)com \
--cc=maciej.fijalkowski@intel$(echo .)com \
--cc=magnus.karlsson@intel$(echo .)com \
--cc=marc.dionne@auristor$(echo .)com \
--cc=marcel@holtmann$(echo .)org \
--cc=marcelo.leitner@gmail$(echo .)com \
--cc=mark.rutland@arm$(echo .)com \
--cc=mark@fasheh$(echo .)com \
--cc=martin@omnibond$(echo .)com \
--cc=mathieu.desnoyers@efficios$(echo .)com \
--cc=mhiramat@kernel$(echo .)org \
--cc=miklos@szeredi$(echo .)hu \
--cc=mikulas@artax$(echo .)karlin.mff.cuni.cz \
--cc=mingo@redhat$(echo .)com \
--cc=mkl@pengutronix$(echo .)de \
--cc=ms@dev$(echo .)tdt.de \
--cc=muchun.song@linux$(echo .)dev \
--cc=namhyung@kernel$(echo .)org \
--cc=naohiro.aota@wdc$(echo .)com \
--cc=ncardwell@google$(echo .)com \
--cc=neil@brown$(echo .)name \
--cc=netdev@vger$(echo .)kernel.org \
--cc=netfs@lists$(echo .)linux.dev \
--cc=nico@fluxnic$(echo .)net \
--cc=ntfs3@lists$(echo .)linux.dev \
--cc=nvdimm@lists$(echo .)linux.dev \
--cc=ocfs2-devel@lists$(echo .)linux.dev \
--cc=okorniev@redhat$(echo .)com \
--cc=oleg@redhat$(echo .)com \
--cc=omosnace@redhat$(echo .)com \
--cc=osalvador@suse$(echo .)de \
--cc=pabeni@redhat$(echo .)com \
--cc=paul@paul-moore$(echo .)com \
--cc=pc@manguebit$(echo .)org \
--cc=peterz@infradead$(echo .)org \
--cc=raven@themaw$(echo .)net \
--cc=richard@nod$(echo .)at \
--cc=roberto.sassu@huawei$(echo .)com \
--cc=ronniesahlberg@gmail$(echo .)com \
--cc=rostedt@goodmis$(echo .)org \
--cc=salah.triki@gmail$(echo .)com \
--cc=samba-technical@lists$(echo .)samba.org \
--cc=sdf@fomichev$(echo .)me \
--cc=selinux@vger$(echo .)kernel.org \
--cc=serge@hallyn$(echo .)com \
--cc=sfrench@samba$(echo .)org \
--cc=shaggy@kernel$(echo .)org \
--cc=simona@ffwll$(echo .)ch \
--cc=slava@dubeyko$(echo .)com \
--cc=socketcan@hartkopp$(echo .)net \
--cc=sprasad@microsoft$(echo .)com \
--cc=steffen.klassert@secunet$(echo .)com \
--cc=stephen.smalley.work@gmail$(echo .)com \
--cc=sumit.semwal@linaro$(echo .)org \
--cc=tom@talpey$(echo .)com \
--cc=trondmy@kernel$(echo .)org \
--cc=tytso@mit$(echo .)edu \
--cc=v9fs@lists$(echo .)linux.dev \
--cc=viro@zeniv$(echo .)linux.org.uk \
--cc=willemb@google$(echo .)com \
--cc=wufan@kernel$(echo .)org \
--cc=zohar@linux$(echo .)ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox