From: "Russell King (Oracle)" <linux@armlinux•org.uk>
To: Andrew Lunn <andrew@lunn•ch>
Cc: Alexandre Torgue <alexandre.torgue@foss•st.com>,
Andrew Lunn <andrew+netdev@lunn•ch>,
Conor Dooley <conor+dt@kernel•org>,
"David S. Miller" <davem@davemloft•net>,
devicetree@vger•kernel.org, Eric Dumazet <edumazet@google•com>,
Giuseppe Cavallaro <peppe.cavallaro@st•com>,
Jakub Kicinski <kuba@kernel•org>,
Jose Abreu <joabreu@synopsys•com>,
Krzysztof Kozlowski <krzk+dt@kernel•org>,
netdev@vger•kernel.org, Paolo Abeni <pabeni@redhat•com>,
Rob Herring <robh@kernel•org>
Subject: Re: [PATCH] dt-bindings: mark unimplemented AXI snps,kbbe snps,mb and snps,rb
Date: Sat, 7 Mar 2026 00:05:18 +0000 [thread overview]
Message-ID: <aatrvmyW-SaHuVN7@shell.armlinux.org.uk> (raw)
In-Reply-To: <E1vxq3L-0000000BsQm-4C8v@rmk-PC.armlinux.org.uk>
Any chance of a review from the DT maintainers please?
Thanks.
On Wed, Mar 04, 2026 at 05:30:32PM +0000, Russell King (Oracle) wrote:
> Mark the AXI snps,kbbe snps,mb and snps,rb properties as not
> implemented. These were introduced by commit afea03656add ("stmmac:
> rework DMA bus setting and introduce new platform AXI structure").
> While stmmac has code to parse these properties and save their values,
> these are written to write-only struct members - no code in stmmac
> has ever read their value. Hence, these properties have been non-
> functional from day one.
>
> Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux•org.uk>
> ---
> Documentation/devicetree/bindings/net/snps,dwmac.yaml | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> index 38bc34dc4f09..45dba6533458 100644
> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> @@ -202,11 +202,11 @@ title: Synopsys DesignWare MAC
> * snps,xit_frm, unlock on WoL
> * snps,wr_osr_lmt, max write outstanding req. limit
> * snps,rd_osr_lmt, max read outstanding req. limit
> - * snps,kbbe, do not cross 1KiB boundary.
> + * snps,kbbe, do not cross 1KiB boundary (not implemented)
> * snps,blen, this is a vector of supported burst length.
> * snps,fb, fixed-burst
> - * snps,mb, mixed-burst
> - * snps,rb, rebuild INCRx Burst
> + * snps,mb, mixed-burst (not implemented)
> + * snps,rb, rebuild INCRx Burst (not implemented)
>
> snps,mtl-rx-config:
> $ref: /schemas/types.yaml#/definitions/phandle
> --
> 2.47.3
>
>
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2026-03-07 0:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-04 17:30 [PATCH] dt-bindings: mark unimplemented AXI snps,kbbe snps,mb and snps,rb Russell King (Oracle)
2026-03-07 0:05 ` Russell King (Oracle) [this message]
2026-03-09 17:49 ` Conor Dooley
2026-03-10 8:43 ` Krzysztof Kozlowski
2026-03-10 8:48 ` Krzysztof Kozlowski
2026-03-10 11:09 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aatrvmyW-SaHuVN7@shell.armlinux.org.uk \
--to=linux@armlinux$(echo .)org.uk \
--cc=alexandre.torgue@foss$(echo .)st.com \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=andrew@lunn$(echo .)ch \
--cc=conor+dt@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=edumazet@google$(echo .)com \
--cc=joabreu@synopsys$(echo .)com \
--cc=krzk+dt@kernel$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=peppe.cavallaro@st$(echo .)com \
--cc=robh@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox