From: Stanislav Fomichev <stfomichev@gmail•com>
To: "Loktionov, Aleksandr" <aleksandr.loktionov@intel•com>
Cc: Stanislav Fomichev <sdf@fomichev•me>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"davem@davemloft•net" <davem@davemloft•net>,
"edumazet@google•com" <edumazet@google•com>,
"kuba@kernel•org" <kuba@kernel•org>,
"pabeni@redhat•com" <pabeni@redhat•com>,
"horms@kernel•org" <horms@kernel•org>,
"corbet@lwn•net" <corbet@lwn•net>,
"skhan@linuxfoundation•org" <skhan@linuxfoundation•org>,
"andrew+netdev@lunn•ch" <andrew+netdev@lunn•ch>,
"michael.chan@broadcom•com" <michael.chan@broadcom•com>,
"pavan.chebbi@broadcom•com" <pavan.chebbi@broadcom•com>,
"Nguyen, Anthony L" <anthony.l.nguyen@intel•com>,
"Kitszel, Przemyslaw" <przemyslaw.kitszel@intel•com>,
"saeedm@nvidia•com" <saeedm@nvidia•com>,
"tariqt@nvidia•com" <tariqt@nvidia•com>,
"mbloch@nvidia•com" <mbloch@nvidia•com>,
"alexanderduyck@fb•com" <alexanderduyck@fb•com>,
"kernel-team@meta•com" <kernel-team@meta•com>,
"johannes@sipsolutions•net" <johannes@sipsolutions•net>,
"sd@queasysnail•net" <sd@queasysnail•net>,
"jianbol@nvidia•com" <jianbol@nvidia•com>,
"dtatulea@nvidia•com" <dtatulea@nvidia•com>,
"mohsin.bashr@gmail•com" <mohsin.bashr@gmail•com>,
"Keller, Jacob E" <jacob.e.keller@intel•com>,
"willemb@google•com" <willemb@google•com>,
"skhawaja@google•com" <skhawaja@google•com>,
"bestswngs@gmail•com" <bestswngs@gmail•com>,
"kees@kernel•org" <kees@kernel•org>,
"linux-doc@vger•kernel.org" <linux-doc@vger•kernel.org>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
"intel-wired-lan@lists•osuosl.org"
<intel-wired-lan@lists•osuosl.org>,
"linux-rdma@vger•kernel.org" <linux-rdma@vger•kernel.org>,
"linux-wireless@vger•kernel.org" <linux-wireless@vger•kernel.org>,
"linux-kselftest@vger•kernel.org"
<linux-kselftest@vger•kernel.org>,
"leon@kernel•org" <leon@kernel•org>
Subject: Re: [Intel-wired-lan] [PATCH net-next v3 03/13] net: introduce ndo_set_rx_mode_async and dev_rx_mode_work
Date: Fri, 20 Mar 2026 08:49:20 -0700 [thread overview]
Message-ID: <ab1sgEg9ii3se1Zq@mini-arch> (raw)
In-Reply-To: <IA3PR11MB89865C96824F6518F4A01B9CE54CA@IA3PR11MB8986.namprd11.prod.outlook.com>
On 03/20, Loktionov, Aleksandr wrote:
>
>
> > -----Original Message-----
> > From: Intel-wired-lan <intel-wired-lan-bounces@osuosl•org> On Behalf
> > Of Stanislav Fomichev
> > Sent: Friday, March 20, 2026 2:25 AM
> > To: netdev@vger•kernel.org
> > Cc: davem@davemloft•net; edumazet@google•com; kuba@kernel•org;
> > pabeni@redhat•com; horms@kernel•org; corbet@lwn•net;
> > skhan@linuxfoundation•org; andrew+netdev@lunn•ch;
> > michael.chan@broadcom•com; pavan.chebbi@broadcom•com; Nguyen, Anthony
> > L <anthony.l.nguyen@intel•com>; Kitszel, Przemyslaw
> > <przemyslaw.kitszel@intel•com>; saeedm@nvidia•com; tariqt@nvidia•com;
> > mbloch@nvidia•com; alexanderduyck@fb•com; kernel-team@meta•com;
> > johannes@sipsolutions•net; sd@queasysnail•net; jianbol@nvidia•com;
> > dtatulea@nvidia•com; sdf@fomichev•me; mohsin.bashr@gmail•com; Keller,
> > Jacob E <jacob.e.keller@intel•com>; willemb@google•com;
> > skhawaja@google•com; bestswngs@gmail•com; Loktionov, Aleksandr
> > <aleksandr.loktionov@intel•com>; kees@kernel•org; linux-
> > doc@vger•kernel.org; linux-kernel@vger•kernel.org; intel-wired-
> > lan@lists•osuosl.org; linux-rdma@vger•kernel.org; linux-
> > wireless@vger•kernel.org; linux-kselftest@vger•kernel.org;
> > leon@kernel•org
> > Subject: [Intel-wired-lan] [PATCH net-next v3 03/13] net: introduce
> > ndo_set_rx_mode_async and dev_rx_mode_work
> >
> > Add ndo_set_rx_mode_async callback that drivers can implement instead
> > of the legacy ndo_set_rx_mode. The legacy callback runs under the
> > netif_addr_lock spinlock with BHs disabled, preventing drivers from
> > sleeping. The async variant runs from a work queue with rtnl_lock and
> > netdev_lock_ops held, in fully sleepable context.
> >
> > When __dev_set_rx_mode() sees ndo_set_rx_mode_async, it schedules
> > dev_rx_mode_work instead of calling the driver inline. The work
> > function takes two snapshots of each address list (uc/mc) under the
> > addr_lock, then drops the lock and calls the driver with the work
> > copies. After the driver returns, it reconciles the snapshots back to
> > the real lists under the lock.
> >
> > Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel•com>
> > Signed-off-by: Stanislav Fomichev <sdf@fomichev•me>
> > ---
> > Documentation/networking/netdevices.rst | 8 +++
> > include/linux/netdevice.h | 20 ++++++
> > net/core/dev.c | 95 +++++++++++++++++++++++-
> > -
> > 3 files changed, 116 insertions(+), 7 deletions(-)
> >
> > diff --git a/Documentation/networking/netdevices.rst
> > b/Documentation/networking/netdevices.rst
> > index 35704d115312..dc83d78d3b27 100644
> > --- a/Documentation/networking/netdevices.rst
> > +++ b/Documentation/networking/netdevices.rst
> > @@ -289,6 +289,14 @@ struct net_device synchronization rules
> > ndo_set_rx_mode:
> > Synchronization: netif_addr_lock spinlock.
> > Context: BHs disabled
>
> ...
>
> > to
> > +device
> > + * and configure RX filtering.
> > + * @dev: device
> > + *
> > + * When the device doesn't support unicast filtering it is put in
> > +promiscuous
> > + * mode while unicast addresses are present.
> > */
> > void __dev_set_rx_mode(struct net_device *dev) {
> > const struct net_device_ops *ops = dev->netdev_ops;
> >
> > /* dev_open will call this function so the list will stay sane.
> > */
> > - if (!(dev->flags&IFF_UP))
> > + if (!netif_up_and_present(dev))
> > return;
> >
> > - if (!netif_device_present(dev))
> > + if (ops->ndo_set_rx_mode_async) {
> > + queue_work(rx_mode_wq, &dev->rx_mode_work);
> > return;
> This early return skips the legacy core fallback below.
> Before this patch, __dev_set_rx_mode() continued into the
> existing unicast-filter handling when the device did not
> advertise IFF_UNICAST_FLT.
>
> After this patch, any driver that implements
> ndo_set_rx_mode_async but does not set IFF_UNICAST_FLT
> will never hit that fallback path.
I believe this is addressed later in "net: move promiscuity handling into
dev_rx_mode_work"? That should take care of doing __dev_set_promiscuity
for !IFF_UNICAST_FLT+ndo_set_rx_mode_async. Not sure if there is a
better way to rearrange the chunks in the patches.
if (ops->ndo_set_rx_mode_async) {
...
+ promisc_inc = dev_uc_promisc_update(dev);
+
+ netif_addr_unlock_bh(dev);
+ } else {
+ netif_addr_lock_bh(dev);
+ promisc_inc = dev_uc_promisc_update(dev);
+ netif_addr_unlock_bh(dev);
+ }
+
+ if (promisc_inc)
+ __dev_set_promiscuity(dev, promisc_inc, false);
+
next prev parent reply other threads:[~2026-03-20 15:49 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-20 1:24 [PATCH net-next v3 00/13] net: sleepable ndo_set_rx_mode Stanislav Fomichev
2026-03-20 1:24 ` [PATCH net-next v3 01/13] net: add address list snapshot and reconciliation infrastructure Stanislav Fomichev
2026-03-23 23:20 ` Jakub Kicinski
2026-03-24 18:13 ` Stanislav Fomichev
2026-03-20 1:24 ` [PATCH net-next v3 02/13] wifi: cfg80211: use __rtnl_unlock in nl80211_pre_doit Stanislav Fomichev
2026-03-20 1:24 ` [PATCH net-next v3 03/13] net: introduce ndo_set_rx_mode_async and dev_rx_mode_work Stanislav Fomichev
2026-03-20 7:13 ` [Intel-wired-lan] " Loktionov, Aleksandr
2026-03-20 15:49 ` Stanislav Fomichev [this message]
2026-03-23 23:20 ` Jakub Kicinski
2026-03-24 18:13 ` Stanislav Fomichev
2026-03-24 21:21 ` Jakub Kicinski
2026-03-24 22:49 ` Stanislav Fomichev
2026-03-25 3:44 ` Jakub Kicinski
2026-03-25 15:06 ` Stanislav Fomichev
2026-03-25 17:34 ` Stanislav Fomichev
2026-03-20 1:24 ` [PATCH net-next v3 04/13] net: move promiscuity handling into dev_rx_mode_work Stanislav Fomichev
2026-03-20 8:01 ` Loktionov, Aleksandr
2026-03-20 15:41 ` Stanislav Fomichev
2026-03-20 1:24 ` [PATCH net-next v3 05/13] fbnic: convert to ndo_set_rx_mode_async Stanislav Fomichev
2026-03-20 1:24 ` [PATCH net-next v3 06/13] mlx5: " Stanislav Fomichev
2026-03-20 14:47 ` Cosmin Ratiu
2026-03-20 15:42 ` Stanislav Fomichev
2026-03-20 1:24 ` [PATCH net-next v3 07/13] bnxt: " Stanislav Fomichev
2026-03-24 0:47 ` Michael Chan
2026-03-20 1:24 ` [PATCH net-next v3 08/13] bnxt: use snapshot in bnxt_cfg_rx_mode Stanislav Fomichev
2026-03-20 7:51 ` Loktionov, Aleksandr
2026-03-24 1:08 ` Michael Chan
2026-03-24 18:29 ` Stanislav Fomichev
2026-03-20 1:24 ` [PATCH net-next v3 09/13] iavf: convert to ndo_set_rx_mode_async Stanislav Fomichev
2026-03-20 7:53 ` Loktionov, Aleksandr
2026-03-20 1:24 ` [PATCH net-next v3 10/13] netdevsim: " Stanislav Fomichev
2026-03-20 1:24 ` [PATCH net-next v3 11/13] dummy: " Stanislav Fomichev
2026-03-20 7:54 ` Loktionov, Aleksandr
2026-03-20 1:25 ` [PATCH net-next v3 12/13] net: warn ops-locked drivers still using ndo_set_rx_mode Stanislav Fomichev
2026-03-20 7:55 ` Loktionov, Aleksandr
2026-03-20 1:25 ` [PATCH net-next v3 13/13] selftests: net: add team_bridge_macvlan rx_mode test Stanislav Fomichev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab1sgEg9ii3se1Zq@mini-arch \
--to=stfomichev@gmail$(echo .)com \
--cc=aleksandr.loktionov@intel$(echo .)com \
--cc=alexanderduyck@fb$(echo .)com \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=anthony.l.nguyen@intel$(echo .)com \
--cc=bestswngs@gmail$(echo .)com \
--cc=corbet@lwn$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=dtatulea@nvidia$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=intel-wired-lan@lists$(echo .)osuosl.org \
--cc=jacob.e.keller@intel$(echo .)com \
--cc=jianbol@nvidia$(echo .)com \
--cc=johannes@sipsolutions$(echo .)net \
--cc=kees@kernel$(echo .)org \
--cc=kernel-team@meta$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=leon@kernel$(echo .)org \
--cc=linux-doc@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-kselftest@vger$(echo .)kernel.org \
--cc=linux-rdma@vger$(echo .)kernel.org \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=mbloch@nvidia$(echo .)com \
--cc=michael.chan@broadcom$(echo .)com \
--cc=mohsin.bashr@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=pavan.chebbi@broadcom$(echo .)com \
--cc=przemyslaw.kitszel@intel$(echo .)com \
--cc=saeedm@nvidia$(echo .)com \
--cc=sd@queasysnail$(echo .)net \
--cc=sdf@fomichev$(echo .)me \
--cc=skhan@linuxfoundation$(echo .)org \
--cc=skhawaja@google$(echo .)com \
--cc=tariqt@nvidia$(echo .)com \
--cc=willemb@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox