Subject: Re: [PATCH 56/61] clk: Prefer IS_ERR_OR_NULL over manual NULL check

From: Brian Masney <[email-masked]>
Date: Tue, 10 Mar 2026 09:21:58 -0400

On Tue, Mar 10, 2026 at 12:49:22PM +0100, Philipp Hahn wrote:
> Prefer using IS_ERR_OR_NULL() over using IS_ERR() and a manual NULL
> check.
> 
> Semantich change: Previously the code only printed the warning on error,

Semantic ...

> but not when the pointer was NULL. Now the warning is printed in both
> cases!
> 
> Change found with coccinelle.
> 
> To: Michael Turquette <[email-masked]>
> To: Stephen Boyd <[email-masked]>
> To: Daniel Lezcano <[email-masked]>
> To: Thomas Gleixner <[email-masked]>
> Cc: [email-masked]
> Cc: [email-masked]
> Signed-off-by: Philipp Hahn <[email-masked]>

With the minor typo addressed:

Reviewed-by: Brian Masney <[email-masked]>