Subject: Re: [PATCH net-next] xsk: remove doubled defines

From: Stanislav Fomichev <[email-masked]>
Date: Tue, 10 Mar 2026 14:34:27 -0700

On 03/10, Maciej Fijalkowski wrote:
> Seems we have been carrying around doubled defines for unaligned mode
> logic. Remove one of them.
> 
> Signed-off-by: Maciej Fijalkowski <[email-masked]>
> ---
>  include/net/xsk_buff_pool.h | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/include/net/xsk_buff_pool.h b/include/net/xsk_buff_pool.h
> index 0b1abdb99c9e..ccb3b350001f 100644
> --- a/include/net/xsk_buff_pool.h
> +++ b/include/net/xsk_buff_pool.h
> @@ -174,13 +174,6 @@ static inline void xp_dma_sync_for_device(struct xsk_buff_pool *pool,
>  	dma_sync_single_for_device(pool->dev, dma, size, DMA_BIDIRECTIONAL);
>  }
>  
> -/* Masks for xdp_umem_page flags.
> - * The low 12-bits of the addr will be 0 since this is the page address, so we
> - * can use them for flags.
> - */
> -#define XSK_NEXT_PG_CONTIG_SHIFT 0
> -#define XSK_NEXT_PG_CONTIG_MASK BIT_ULL(XSK_NEXT_PG_CONTIG_SHIFT)
> -
>  static inline bool xp_desc_crosses_non_contig_pg(struct xsk_buff_pool *pool,
>  						 u64 addr, u32 len)
>  {
> -- 
> 2.43.0
> 

All consumers seem to be in net/xdp/xsk_buff_pool.c, so why not remove
the defines from xsk.h instead?