From: Florian Fainelli <f.fainelli@gmail•com>
To: Andrew Lunn <andrew@lunn•ch>, Vladimir Oltean <vladimir.oltean@nxp•com>
Cc: netdev@vger•kernel.org, Vivien Didelot <vivien.didelot@gmail•com>
Subject: Re: [RFC PATCH net-next 1/2] net: dsa: remove ndo_get_phys_port_name and ndo_get_port_parent_id
Date: Fri, 7 Jan 2022 11:48:30 -0800 [thread overview]
Message-ID: <abc74eaa-dd76-a022-d09d-3845e7e9c7d2@gmail.com> (raw)
In-Reply-To: <YdiWYydfY8flreN4@lunn.ch>
On 1/7/22 11:37 AM, Andrew Lunn wrote:
> On Fri, Jan 07, 2022 at 08:48:41PM +0200, Vladimir Oltean wrote:
>> There are no legacy ports, DSA registers a devlink instance with ports
>> unconditionally for all switch drivers. Therefore, delete the old-style
>> ndo operations used for determining bridge forwarding domains.
>>
>> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp•com>
>
> Hi Vladimir
>
> Maybe ask Ido or Jiri to review this? But none of the Mellanox drivers
> use use these ndo's, suggesting it is correct.
I confirmed that /sys/class/net/*/phys_port_name continues to work
before and after this patch, so:
Reviewed-by: Florian Fainelli <f.fainelli@gmail•com>
Tested-by: Florian Fainelli <f.fainelli@gmail•com>
--
Florian
next prev parent reply other threads:[~2022-01-07 19:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-07 18:48 [RFC PATCH net-next 0/2] More aggressive DSA cleanup Vladimir Oltean
2022-01-07 18:48 ` [RFC PATCH net-next 1/2] net: dsa: remove ndo_get_phys_port_name and ndo_get_port_parent_id Vladimir Oltean
2022-01-07 19:37 ` Andrew Lunn
2022-01-07 19:48 ` Florian Fainelli [this message]
2022-01-07 20:00 ` Vladimir Oltean
2022-01-09 17:25 ` Ido Schimmel
2022-01-10 9:33 ` Jiri Pirko
2022-01-07 18:48 ` [RFC PATCH net-next 2/2] net: dsa: remove lockdep class for DSA master address list Vladimir Oltean
2022-01-07 19:57 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abc74eaa-dd76-a022-d09d-3845e7e9c7d2@gmail.com \
--to=f.fainelli@gmail$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=netdev@vger$(echo .)kernel.org \
--cc=vivien.didelot@gmail$(echo .)com \
--cc=vladimir.oltean@nxp$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox