From: Breno Leitao <leitao@debian•org>
To: Nicolai Buchwitz <nb@tipi-net•de>
Cc: nicolas.ferre@microchip•com, claudiu.beznea@tuxon•dev,
andrew+netdev@lunn•ch, davem@davemloft•net, edumazet@google•com,
kuba@kernel•org, pabeni@redhat•com, netdev@vger•kernel.org
Subject: Re: [PATCH net-next] net: macb: propagate macb_open() failure in macb_set_ringparam()
Date: Wed, 18 Mar 2026 04:19:46 -0700 [thread overview]
Message-ID: <abqKQcjARIquRwsA@gmail.com> (raw)
In-Reply-To: <20260317202229.193375-1-nb@tipi-net.de>
On Tue, Mar 17, 2026 at 09:22:29PM +0100, Nicolai Buchwitz wrote:
> macb_set_ringparam() silently ignores macb_open() failure after
> closing and reopening the interface, always returning 0. Propagate
> the error so callers know the interface failed to come back up.
>
> Suggested-by: Breno Leitao <leitao@debian•org>
> Signed-off-by: Nicolai Buchwitz <nb@tipi-net•de>
Reviewed-by: Breno Leitao <leitao@debian•org>
next prev parent reply other threads:[~2026-03-18 11:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-17 20:22 [PATCH net-next] net: macb: propagate macb_open() failure in macb_set_ringparam() Nicolai Buchwitz
2026-03-18 11:19 ` Breno Leitao [this message]
2026-03-19 2:44 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abqKQcjARIquRwsA@gmail.com \
--to=leitao@debian$(echo .)org \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=claudiu.beznea@tuxon$(echo .)dev \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=nb@tipi-net$(echo .)de \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nicolas.ferre@microchip$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox