From: Stanislav Fomichev <stfomichev@gmail•com>
To: "Loktionov, Aleksandr" <aleksandr.loktionov@intel•com>
Cc: Stanislav Fomichev <sdf@fomichev•me>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"davem@davemloft•net" <davem@davemloft•net>,
"edumazet@google•com" <edumazet@google•com>,
"kuba@kernel•org" <kuba@kernel•org>,
"pabeni@redhat•com" <pabeni@redhat•com>,
"horms@kernel•org" <horms@kernel•org>,
"corbet@lwn•net" <corbet@lwn•net>,
"skhan@linuxfoundation•org" <skhan@linuxfoundation•org>,
"andrew+netdev@lunn•ch" <andrew+netdev@lunn•ch>,
"michael.chan@broadcom•com" <michael.chan@broadcom•com>,
"pavan.chebbi@broadcom•com" <pavan.chebbi@broadcom•com>,
"Nguyen, Anthony L" <anthony.l.nguyen@intel•com>,
"Kitszel, Przemyslaw" <przemyslaw.kitszel@intel•com>,
"saeedm@nvidia•com" <saeedm@nvidia•com>,
"tariqt@nvidia•com" <tariqt@nvidia•com>,
"mbloch@nvidia•com" <mbloch@nvidia•com>,
"alexanderduyck@fb•com" <alexanderduyck@fb•com>,
"kernel-team@meta•com" <kernel-team@meta•com>,
"johannes@sipsolutions•net" <johannes@sipsolutions•net>,
"sd@queasysnail•net" <sd@queasysnail•net>,
"jianbol@nvidia•com" <jianbol@nvidia•com>,
"dtatulea@nvidia•com" <dtatulea@nvidia•com>,
"mohsin.bashr@gmail•com" <mohsin.bashr@gmail•com>,
"Keller, Jacob E" <jacob.e.keller@intel•com>,
"willemb@google•com" <willemb@google•com>,
"skhawaja@google•com" <skhawaja@google•com>,
"bestswngs@gmail•com" <bestswngs@gmail•com>,
"linux-doc@vger•kernel.org" <linux-doc@vger•kernel.org>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
"intel-wired-lan@lists•osuosl.org"
<intel-wired-lan@lists•osuosl.org>,
"linux-rdma@vger•kernel.org" <linux-rdma@vger•kernel.org>,
"linux-wireless@vger•kernel.org" <linux-wireless@vger•kernel.org>,
"linux-kselftest@vger•kernel.org"
<linux-kselftest@vger•kernel.org>,
"leon@kernel•org" <leon@kernel•org>
Subject: Re: [Intel-wired-lan] [PATCH net-next v2 08/13] bnxt: use snapshot in bnxt_cfg_rx_mode
Date: Thu, 19 Mar 2026 08:54:28 -0700 [thread overview]
Message-ID: <abwcNMcZHW0ThCkW@mini-arch> (raw)
In-Reply-To: <IA3PR11MB89866985981DB64EFEBDF0ACE54FA@IA3PR11MB8986.namprd11.prod.outlook.com>
On 03/19, Loktionov, Aleksandr wrote:
>
>
> > -----Original Message-----
> > From: Intel-wired-lan <intel-wired-lan-bounces@osuosl•org> On Behalf
> > Of Stanislav Fomichev
> > Sent: Wednesday, March 18, 2026 4:03 PM
> > To: netdev@vger•kernel.org
> > Cc: davem@davemloft•net; edumazet@google•com; kuba@kernel•org;
> > pabeni@redhat•com; horms@kernel•org; corbet@lwn•net;
> > skhan@linuxfoundation•org; andrew+netdev@lunn•ch;
> > michael.chan@broadcom•com; pavan.chebbi@broadcom•com; Nguyen, Anthony
> > L <anthony.l.nguyen@intel•com>; Kitszel, Przemyslaw
> > <przemyslaw.kitszel@intel•com>; saeedm@nvidia•com; tariqt@nvidia•com;
> > mbloch@nvidia•com; alexanderduyck@fb•com; kernel-team@meta•com;
> > johannes@sipsolutions•net; sd@queasysnail•net; jianbol@nvidia•com;
> > dtatulea@nvidia•com; sdf@fomichev•me; mohsin.bashr@gmail•com; Keller,
> > Jacob E <jacob.e.keller@intel•com>; willemb@google•com;
> > skhawaja@google•com; bestswngs@gmail•com; linux-doc@vger•kernel.org;
> > linux-kernel@vger•kernel.org; intel-wired-lan@lists•osuosl.org; linux-
> > rdma@vger•kernel.org; linux-wireless@vger•kernel.org; linux-
> > kselftest@vger•kernel.org; leon@kernel•org
> > Subject: [Intel-wired-lan] [PATCH net-next v2 08/13] bnxt: use
> > snapshot in bnxt_cfg_rx_mode
> >
> > With the introduction of ndo_set_rx_mode_async (as discussed in [0])
> > we can call bnxt_cfg_rx_mode directly. Convert bnxt_cfg_rx_mode to use
> > uc/mc snapshots and move its call in bnxt_sp_task to the section that
> > resets BNXT_STATE_IN_SP_TASK. Switch to direct call in
> > bnxt_set_rx_mode.
> >
> > 0:
> > https://lore.kernel.org/netdev/CACKFLi=5vj8hPqEUKDd8RTw3au5G+zRgQEqjF+
> > 6NZnyoNm90KA@mail•gmail.com/
> >
> > Cc: Michael Chan <michael.chan@broadcom•com>
> > Cc: Pavan Chebbi <pavan.chebbi@broadcom•com>
> > Signed-off-by: Stanislav Fomichev <sdf@fomichev•me>
> > ---
> > drivers/net/ethernet/broadcom/bnxt/bnxt.c | 24 ++++++++++++++--------
> > -
> > 1 file changed, 15 insertions(+), 9 deletions(-)
>
> ...
>
> > -static int bnxt_cfg_rx_mode(struct bnxt *bp)
> > +static int bnxt_cfg_rx_mode(struct bnxt *bp, struct
> > netdev_hw_addr_list *uc,
> > + struct netdev_hw_addr_list *mc)
> > {
> > struct net_device *dev = bp->dev;
> > struct bnxt_vnic_info *vnic = &bp-
> > >vnic_info[BNXT_VNIC_DEFAULT];
> > @@ -13623,7 +13625,7 @@ static int bnxt_cfg_rx_mode(struct bnxt *bp)
> > bool uc_update;
> >
> > netif_addr_lock_bh(dev);
> > - uc_update = bnxt_uc_list_updated(bp, &dev->uc);
> > + uc_update = bnxt_uc_list_updated(bp, uc);
> > netif_addr_unlock_bh(dev);
> >
> > if (!uc_update)
> > @@ -13642,7 +13644,7 @@ static int bnxt_cfg_rx_mode(struct bnxt *bp)
> > if (netdev_uc_count(dev) > (BNXT_MAX_UC_ADDRS - 1)) {
> > vnic->rx_mask |=
> > CFA_L2_SET_RX_MASK_REQ_MASK_PROMISCUOUS;
> This limit check uses the live device list, dev->uc.
> In the new async model, the live list can differ from the snapshot.
Oh, yes, good catch! Will do s/netdev_uc_count/netdev_hw_addr_list_count(uc).
next prev parent reply other threads:[~2026-03-19 15:54 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-18 15:02 [PATCH net-next v2 00/13] net: sleepable ndo_set_rx_mode Stanislav Fomichev
2026-03-18 15:02 ` [PATCH net-next v2 01/13] net: add address list snapshot and reconciliation infrastructure Stanislav Fomichev
2026-03-18 15:40 ` [Intel-wired-lan] " Loktionov, Aleksandr
2026-03-18 15:02 ` [PATCH net-next v2 02/13] wifi: cfg80211: use __rtnl_unlock in nl80211_pre_doit Stanislav Fomichev
2026-03-18 15:41 ` [Intel-wired-lan] " Loktionov, Aleksandr
2026-03-18 16:16 ` Stanislav Fomichev
2026-03-19 9:16 ` [Intel-wired-lan] " kernel test robot
2026-03-19 19:22 ` kernel test robot
2026-03-18 15:02 ` [PATCH net-next v2 03/13] net: introduce ndo_set_rx_mode_async and dev_rx_mode_work Stanislav Fomichev
2026-03-18 15:42 ` [Intel-wired-lan] " Loktionov, Aleksandr
2026-03-23 12:09 ` Loktionov, Aleksandr
2026-03-18 15:02 ` [PATCH net-next v2 04/13] net: move promiscuity handling into dev_rx_mode_work Stanislav Fomichev
2026-03-18 15:43 ` [Intel-wired-lan] " Loktionov, Aleksandr
2026-03-18 15:02 ` [PATCH net-next v2 05/13] fbnic: convert to ndo_set_rx_mode_async Stanislav Fomichev
2026-03-18 15:43 ` [Intel-wired-lan] " Loktionov, Aleksandr
2026-03-18 15:02 ` [PATCH net-next v2 06/13] mlx5: " Stanislav Fomichev
2026-03-18 15:44 ` [Intel-wired-lan] " Loktionov, Aleksandr
2026-03-18 15:02 ` [PATCH net-next v2 07/13] bnxt: " Stanislav Fomichev
2026-03-18 15:45 ` [Intel-wired-lan] " Loktionov, Aleksandr
2026-03-18 15:03 ` [PATCH net-next v2 08/13] bnxt: use snapshot in bnxt_cfg_rx_mode Stanislav Fomichev
2026-03-19 8:31 ` [Intel-wired-lan] " Loktionov, Aleksandr
2026-03-19 15:54 ` Stanislav Fomichev [this message]
2026-03-18 15:03 ` [PATCH net-next v2 09/13] iavf: convert to ndo_set_rx_mode_async Stanislav Fomichev
2026-03-18 15:03 ` [PATCH net-next v2 10/13] netdevsim: " Stanislav Fomichev
2026-03-18 15:03 ` [PATCH net-next v2 11/13] dummy: " Stanislav Fomichev
2026-03-18 15:03 ` [PATCH net-next v2 12/13] net: warn ops-locked drivers still using ndo_set_rx_mode Stanislav Fomichev
2026-03-18 15:03 ` [PATCH net-next v2 13/13] selftests: net: add team_bridge_macvlan rx_mode test Stanislav Fomichev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abwcNMcZHW0ThCkW@mini-arch \
--to=stfomichev@gmail$(echo .)com \
--cc=aleksandr.loktionov@intel$(echo .)com \
--cc=alexanderduyck@fb$(echo .)com \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=anthony.l.nguyen@intel$(echo .)com \
--cc=bestswngs@gmail$(echo .)com \
--cc=corbet@lwn$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=dtatulea@nvidia$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=intel-wired-lan@lists$(echo .)osuosl.org \
--cc=jacob.e.keller@intel$(echo .)com \
--cc=jianbol@nvidia$(echo .)com \
--cc=johannes@sipsolutions$(echo .)net \
--cc=kernel-team@meta$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=leon@kernel$(echo .)org \
--cc=linux-doc@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-kselftest@vger$(echo .)kernel.org \
--cc=linux-rdma@vger$(echo .)kernel.org \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=mbloch@nvidia$(echo .)com \
--cc=michael.chan@broadcom$(echo .)com \
--cc=mohsin.bashr@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=pavan.chebbi@broadcom$(echo .)com \
--cc=przemyslaw.kitszel@intel$(echo .)com \
--cc=saeedm@nvidia$(echo .)com \
--cc=sd@queasysnail$(echo .)net \
--cc=sdf@fomichev$(echo .)me \
--cc=skhan@linuxfoundation$(echo .)org \
--cc=skhawaja@google$(echo .)com \
--cc=tariqt@nvidia$(echo .)com \
--cc=willemb@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox