Subject: Re: [PATCH net v6 1/4] selftests: Migrate nsim-only MACsec tests to Python

From: Sabrina Dubroca <[email-masked]>
Date: Thu, 2 Apr 2026 12:03:41 +0200

2026-03-30, 16:01:27 +0300, Cosmin Ratiu wrote:
> -#
> -# test ethtool features when toggling offload
> -#
> -
> -ip link add link $NSIM_NETDEV $MACSEC_NETDEV type macsec offload mac
> -TMP_FEATS_ON_1="$(ethtool -k $MACSEC_NETDEV)"
> -
> -ip link set $MACSEC_NETDEV type macsec offload off
> -TMP_FEATS_OFF_1="$(ethtool -k $MACSEC_NETDEV)"
> -
> -ip link set $MACSEC_NETDEV type macsec offload mac
> -TMP_FEATS_ON_2="$(ethtool -k $MACSEC_NETDEV)"
> -
> -[ "$TMP_FEATS_ON_1" = "$TMP_FEATS_ON_2" ]
> -check $?
[...]
> -TMP_FEATS_OFF_2="$(ethtool -k $MACSEC_NETDEV)"
> -[ "$TMP_FEATS_OFF_1" = "$TMP_FEATS_OFF_2" ]
> -check $?
[...]
> -TMP_FEATS_ON_3="$(ethtool -k $MACSEC_NETDEV)"
> -[ "$TMP_FEATS_ON_1" = "$TMP_FEATS_ON_3" ]
> -check $?

Those feature comparisons are missing in the new python test. The rest
of the patch looks good.

-- 
Sabrina