From: "Russell King (Oracle)" <linux@armlinux•org.uk>
To: Andrew Lunn <andrew@lunn•ch>
Cc: Mark Brown <broonie@kernel•org>,
Dmitry Torokhov <dmitry.torokhov@gmail•com>,
Andrew Lunn <andrew+netdev@lunn•ch>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
Vinod Koul <vkoul@kernel•org>,
Neil Armstrong <neil.armstrong@linaro•org>,
Liam Girdwood <lgirdwood@gmail•com>, Lee Jones <lee@kernel•org>,
Pavel Machek <pavel@kernel•org>, Peter Rosin <peda@axentia•se>,
Heiner Kallweit <hkallweit1@gmail•com>,
Moritz Fischer <mdf@kernel•org>, Xu Yilun <yilun.xu@intel•com>,
Tom Rix <trix@redhat•com>,
Greg Kroah-Hartman <gregkh@linuxfoundation•org>,
"Rafael J. Wysocki" <rafael@kernel•org>,
Danilo Krummrich <dakr@kernel•org>,
netdev@vger•kernel.org, linux-kernel@vger•kernel.org,
linux-phy@lists•infradead.org, linux-spi@vger•kernel.org,
linux-leds@vger•kernel.org, linux-fpga@vger•kernel.org,
driver-core@lists•linux.dev
Subject: Re: [PATCH 04/10] regulator: of: switch to using class_find_device_by_fwnode()
Date: Tue, 24 Mar 2026 00:17:42 +0000 [thread overview]
Message-ID: <acHYJvbSZVPldSCU@shell.armlinux.org.uk> (raw)
In-Reply-To: <cf92122d-6b15-458a-bf89-189a0a6874f7@lunn.ch>
On Mon, Mar 23, 2026 at 09:01:47PM +0100, Andrew Lunn wrote:
> On Mon, Mar 23, 2026 at 07:05:13PM +0000, Mark Brown wrote:
> > On Mon, Mar 23, 2026 at 11:28:27AM -0700, Dmitry Torokhov wrote:
> > > On Mon, Mar 23, 2026 at 02:00:43PM +0000, Mark Brown wrote:
> >
> > > > The regulator API is very deliberately specifically using the OF APIs,
> > > > not the ACPI APIs, since ACPI really doesn't want to model regulators.
> >
> > > For now? We also have software nodes and maybe we come up with something
> > > else in the future...
> >
> > > I think we should use firmware-agnostic APIs as much as possible, and
> > > only use OF- or ACPI-specific ones when there is no generic equivalent.
> > > This makes the code most flexible.
> >
> > I think this is a worrying idea for core code like this, we have
> > specific firmware bindings for specific firmware interfaces with the
> > different interfaces having very different ideas of how things should be
> > modelled. The chances that firmware agnostic code is going to do the
> > right thing seem low, and encouraging the use of generic APIs that might
> > happen to run OK raises the risk that we'll get firmware vendors relying
> > on them and leaving us with a conceptual mishmash to sort through.
>
> How do you handle deprecated OF properties? This is a problem i've run
> into before. A developer needs an ACPI binding, so they blindly
> convert from of_ to device_ without engaging brain. As a result, they
> bring all the deprecated OF properties we want to die into the brand
> new ACPI bindings.
>
> A agree with Mark here. OF != ACPI, and anything which makes it appear
> they are the same is just going to lead developers down the wrong path
> and increase Maintainers work pointing out all the problems.
That's three who agree.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2026-03-24 0:18 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-23 1:54 [PATCH 00/10] Remove class_find_device_by_of_node in favor of finding by firmware node Dmitry Torokhov
2026-03-23 1:54 ` [PATCH net-next 01/10] net: wan: framer: switch to using class_find_device_by_fwnode() Dmitry Torokhov
2026-03-23 1:54 ` [PATCH 02/10] phy: core: " Dmitry Torokhov
2026-05-10 11:26 ` Vinod Koul
2026-03-23 1:54 ` [PATCH 03/10] spi: " Dmitry Torokhov
2026-03-23 13:58 ` Mark Brown
2026-03-23 17:16 ` Mark Brown
2026-03-23 18:25 ` Dmitry Torokhov
2026-03-23 1:54 ` [PATCH 04/10] regulator: of: " Dmitry Torokhov
2026-03-23 14:00 ` Mark Brown
2026-03-23 18:28 ` Dmitry Torokhov
2026-03-23 19:05 ` Mark Brown
2026-03-23 19:41 ` Dmitry Torokhov
2026-03-23 19:58 ` Mark Brown
2026-03-23 21:39 ` Dmitry Torokhov
2026-03-23 20:01 ` Andrew Lunn
2026-03-23 21:36 ` Mark Brown
2026-03-23 21:41 ` Dmitry Torokhov
2026-03-23 22:11 ` Andrew Lunn
2026-03-23 22:27 ` Dmitry Torokhov
2026-03-23 22:39 ` Andrew Lunn
2026-03-23 22:48 ` Dmitry Torokhov
2026-03-24 13:50 ` Andrew Lunn
2026-03-24 0:17 ` Russell King (Oracle) [this message]
2026-03-23 1:54 ` [PATCH 05/10] leds: led-class: " Dmitry Torokhov
2026-03-31 10:29 ` (subset) " Lee Jones
2026-03-23 1:54 ` [PATCH 06/10] mux: " Dmitry Torokhov
2026-03-23 1:54 ` [PATCH net-next 07/10] net: phy: " Dmitry Torokhov
2026-03-23 2:54 ` Andrew Lunn
2026-03-23 5:17 ` Dmitry Torokhov
2026-03-23 8:59 ` Russell King (Oracle)
2026-03-23 18:33 ` Dmitry Torokhov
2026-03-23 18:39 ` Russell King (Oracle)
2026-03-23 19:35 ` Dmitry Torokhov
2026-03-23 20:15 ` Andrew Lunn
2026-03-23 21:49 ` Dmitry Torokhov
2026-03-23 22:00 ` Andrew Lunn
2026-03-23 22:20 ` Dmitry Torokhov
2026-03-23 1:54 ` [PATCH 08/10] fpga: bridge: " Dmitry Torokhov
2026-03-23 1:54 ` [PATCH 09/10] fpga: manager: " Dmitry Torokhov
2026-03-23 1:54 ` [PATCH 10/10] driver core: class: remove class_find_device_by_of_node() Dmitry Torokhov
2026-03-23 7:43 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acHYJvbSZVPldSCU@shell.armlinux.org.uk \
--to=linux@armlinux$(echo .)org.uk \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=andrew@lunn$(echo .)ch \
--cc=broonie@kernel$(echo .)org \
--cc=dakr@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=dmitry.torokhov@gmail$(echo .)com \
--cc=driver-core@lists$(echo .)linux.dev \
--cc=edumazet@google$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=hkallweit1@gmail$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=lee@kernel$(echo .)org \
--cc=lgirdwood@gmail$(echo .)com \
--cc=linux-fpga@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-leds@vger$(echo .)kernel.org \
--cc=linux-phy@lists$(echo .)infradead.org \
--cc=linux-spi@vger$(echo .)kernel.org \
--cc=mdf@kernel$(echo .)org \
--cc=neil.armstrong@linaro$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=pavel@kernel$(echo .)org \
--cc=peda@axentia$(echo .)se \
--cc=rafael@kernel$(echo .)org \
--cc=trix@redhat$(echo .)com \
--cc=vkoul@kernel$(echo .)org \
--cc=yilun.xu@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox