Subject: Re: [PATCH net] net: sfp: Fix Ubiquiti U-Fiber Instant SFP module on mvneta

From: "Russell King (Oracle)" <[email-masked]>
Date: Thu, 26 Mar 2026 15:19:36 +0000

On Thu, Mar 26, 2026 at 01:20:38PM +0100, Marek Behún wrote:
> In commit 8110633db49d7de2 ("net: sfp-bus: allow SFP quirks to override
> Autoneg and pause bits") we moved the setting of Autoneg and pause bits
> before the call to SFP quirk when parsing SFP module support.
> 
> Since the quirk for Ubiquiti U-Fiber Instant SFP module zeroes the
> support bits and sets 1000baseX_Full only, the above mentioned commit
> changed the overall computed support from
>   1000baseX_Full, Autoneg, Pause, Asym_Pause
> to just
>   1000baseX_Full.
> 
> This broke the SFP module for mvneta, which requires Autoneg for
> 1000baseX since commit c762b7fac1b249a9 ("net: mvneta: deny disabling
> autoneg for 802.3z modes").
> 
> Fix this by setting back the Autoneg, Pause and Asym_Pause bits in the
> quirk.
> 
> Fixes: 8110633db49d7de2 ("net: sfp-bus: allow SFP quirks to override Autoneg and pause bits")
> Signed-off-by: Marek Behún <[email-masked]>

Reviewed-by: Russell King (Oracle) <[email-masked]>

Thanks!

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!