From: Petr Mladek <pmladek@suse•com>
To: David Laight <david.laight.linux@gmail•com>
Cc: Pablo Neira Ayuso <pablo@netfilter•org>,
Florian Westphal <fw@strlen•de>, Phil Sutter <phil@nwl•cc>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
Simon Horman <horms@kernel•org>,
netfilter-devel@vger•kernel.org, coreteam@netfilter•org,
netdev@vger•kernel.org, linux-kernel@vger•kernel.org,
Masami Hiramatsu <mhiramat@kernel•org>,
Rasmus Villemoes <linux@rasmusvillemoes•dk>,
Andy Shevchenko <andriy.shevchenko@linux•intel.com>,
Steven Rostedt <rostedt@goodmis•org>,
Sergey Senozhatsky <senozhatsky@chromium•org>,
Andrew Morton <akpm@linux-foundation•org>
Subject: Re: [PATCH next] netfilter: nf_conntrack_h323: Correct indentation when H323_TRACE defined
Date: Fri, 27 Mar 2026 14:11:23 +0100 [thread overview]
Message-ID: <acaB-0VR1sAXPsed@pathway.suse.cz> (raw)
In-Reply-To: <20260327125527.13aaf590@pumpkin>
On Fri 2026-03-27 12:55:27, David Laight wrote:
> On Fri, 27 Mar 2026 10:47:41 +0100
> Petr Mladek <pmladek@suse•com> wrote:
>
> > On Thu 2026-03-26 20:18:19, david.laight.linux@gmail•com wrote:
> > > From: David Laight <david.laight.linux@gmail•com>
> > >
> > > The trace lines are indented using PRINT("%*.s", xx, " ").
> > > Userspace will treat this as "%*.0s" and will output no characters
> > > when 'xx' is zero, the kernel treats it as "%*s" and will output
> > > a single ' ' - which is probably what is intended.
> > >
> > > Change all the formats to "%*s" removing the default precision.
> > > This gives a single space indent when level is zero.
> > >
> > > Signed-off-by: David Laight <david.laight.linux@gmail•com>
> > > ---
> > > net/netfilter/nf_conntrack_h323_asn1.c | 38 +++++++++++++-------------
> > > 1 file changed, 19 insertions(+), 19 deletions(-)
> > >
> > > diff --git a/net/netfilter/nf_conntrack_h323_asn1.c b/net/netfilter/nf_conntrack_h323_asn1.c
> > > index 7b1497ed97d2..287402428975 100644
> > > --- a/net/netfilter/nf_conntrack_h323_asn1.c
> > > +++ b/net/netfilter/nf_conntrack_h323_asn1.c
> > > @@ -276,7 +276,7 @@ static unsigned int get_uint(struct bitstr *bs, int b)
> > > static int decode_nul(struct bitstr *bs, const struct field_t *f,
> > > char *base, int level)
> > > {
> > > - PRINT("%*.s%s\n", level * TAB_SIZE, " ", f->name);
> > > + PRINT("%*s%s\n", level * TAB_SIZE, " ", f->name);
> > >
> > > return H323_ERROR_NONE;
> > > }
> >
> > The change is important for making the kernel %*.s handling POSIX
> > compliant. The dot '.' without any following number is handled
> > a zero precision by POSIX. It would print no space "" when
> > also the field width was zero, aka when level == 0.
> >
> > It has no efect if the field width (@level) is always > 0 because
> > vsprintf() would add the required emptry spaces ' ' anyway.
>
> That looks like C&P AI output...
I believe that these days AI would be able to formulate it a much better
way than me.
Best Regards,
Petr
prev parent reply other threads:[~2026-03-27 13:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-26 20:18 [PATCH next] netfilter: nf_conntrack_h323: Correct indentation when H323_TRACE defined david.laight.linux
2026-03-26 20:24 ` Pablo Neira Ayuso
2026-03-26 22:18 ` David Laight
2026-03-27 9:24 ` Andy Shevchenko
2026-03-27 9:51 ` David Laight
2026-03-27 9:47 ` Petr Mladek
2026-03-27 12:55 ` David Laight
2026-03-27 13:11 ` Petr Mladek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acaB-0VR1sAXPsed@pathway.suse.cz \
--to=pmladek@suse$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=andriy.shevchenko@linux$(echo .)intel.com \
--cc=coreteam@netfilter$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=david.laight.linux@gmail$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=fw@strlen$(echo .)de \
--cc=horms@kernel$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux@rasmusvillemoes$(echo .)dk \
--cc=mhiramat@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=netfilter-devel@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=pablo@netfilter$(echo .)org \
--cc=phil@nwl$(echo .)cc \
--cc=rostedt@goodmis$(echo .)org \
--cc=senozhatsky@chromium$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox