From: Nikolay Aleksandrov <nikolay@cumulusnetworks•com>
To: Petr Machata <petrm@mellanox•com>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>
Cc: Jiri Pirko <jiri@mellanox•com>,
Ido Schimmel <idosch@mellanox•com>,
"davem@davemloft•net" <davem@davemloft•net>,
"ivecera@redhat•com" <ivecera@redhat•com>,
Roopa Prabhu <roopa@cumulusnetworks•com>,
David Ahern <dsa@cumulusnetworks•com>,
"bridge@lists•linux-foundation.org"
<bridge@lists•linux-foundation.org>
Subject: Re: [PATCH net-next 2/9] net: bridge: Propagate extack to switchdev
Date: Wed, 12 Dec 2018 14:20:02 +0200 [thread overview]
Message-ID: <acdc5d71-e95d-e208-c141-a817b52b6097@cumulusnetworks.com> (raw)
In-Reply-To: <ec46d51de1641ef2fd012fd3474935d6ee72edaf.1544614445.git.petrm@mellanox.com>
On 12/12/2018 13:52, Petr Machata wrote:
> ndo_bridge_setlink has been updated in the previous patch to have extack
> available, and changelink RTNL op has had this argument since the time
> extack was added. Propagate both through the bridge driver to eventually
> reach br_switchdev_port_vlan_add(), where it will be used by subsequent
> patches.
>
> Signed-off-by: Petr Machata <petrm@mellanox•com>
> Acked-by: Jiri Pirko <jiri@mellanox•com>
> ---
> net/bridge/br_if.c | 2 +-
> net/bridge/br_netlink.c | 27 +++++++++++++---------
> net/bridge/br_private.h | 22 ++++++++++--------
> net/bridge/br_switchdev.c | 3 ++-
> net/bridge/br_vlan.c | 59 ++++++++++++++++++++++++++---------------------
> 5 files changed, 65 insertions(+), 48 deletions(-)
>
+CC Roopa & bridge list
Looks good to me.
Acked-by: Nikolay Aleksandrov <nikolay@cumulusnetworks•com>
next prev parent reply other threads:[~2018-12-12 12:20 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-12 11:52 [PATCH net-next 0/9] Pass extack to SWITCHDEV_PORT_OBJ_ADD Petr Machata
2018-12-12 11:52 ` [PATCH net-next 1/9] net: ndo_bridge_setlink: Add extack Petr Machata
2018-12-12 12:26 ` Nikolay Aleksandrov
2018-12-12 13:58 ` Petr Machata
2018-12-12 11:52 ` [PATCH net-next 2/9] net: bridge: Propagate extack to switchdev Petr Machata
2018-12-12 12:20 ` Nikolay Aleksandrov [this message]
2018-12-12 13:05 ` Ivan Vecera
2018-12-12 15:33 ` Roopa Prabhu
2018-12-12 11:52 ` [PATCH net-next 3/9] net: switchdev: Add extack argument to switchdev_port_obj_add() Petr Machata
2018-12-12 13:11 ` Ivan Vecera
2018-12-12 11:52 ` [PATCH net-next 4/9] net: switchdev: Add extack to struct switchdev_notifier_info Petr Machata
2018-12-12 13:12 ` Ivan Vecera
2018-12-12 11:52 ` [PATCH net-next 5/9] net: switchdev: Add extack to switchdev_handle_port_obj_add() callback Petr Machata
2018-12-12 13:12 ` Ivan Vecera
2018-12-12 11:52 ` [PATCH net-next 6/9] mlxsw: spectrum_switchdev: Propagate extack on VXLAN VLAN events Petr Machata
2018-12-12 11:52 ` [PATCH net-next 7/9] mlxsw: spectrum_switchdev: Propagate extack on port " Petr Machata
2018-12-12 11:52 ` [PATCH net-next 8/9] selftests: mlxsw: extack: Test VLAN add on a VXLAN device Petr Machata
2018-12-12 11:52 ` [PATCH net-next 9/9] selftests: mlxsw: extack: Test VLAN add on a port device Petr Machata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acdc5d71-e95d-e208-c141-a817b52b6097@cumulusnetworks.com \
--to=nikolay@cumulusnetworks$(echo .)com \
--cc=bridge@lists$(echo .)linux-foundation.org \
--cc=davem@davemloft$(echo .)net \
--cc=dsa@cumulusnetworks$(echo .)com \
--cc=idosch@mellanox$(echo .)com \
--cc=ivecera@redhat$(echo .)com \
--cc=jiri@mellanox$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=petrm@mellanox$(echo .)com \
--cc=roopa@cumulusnetworks$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox