Subject: Re: [PATCH 10/14 v2] nes: eeprom and phy routines

From: Roland Dreier <[email-masked]>
Date: Wed, 31 Oct 2007 13:26:29 -0700

> +	/* TODO: deal with EEPROM endian issues */

This is pretty scary.  Is the driver broken on big-endian systems now?

 > +/*
 > +"Everything you wanted to know about CRC algorithms, but were afraid to ask
 > + for fear that errors in your understanding might be detected." Version  : 3.

etc etc... can all this be replaced with what's in lib/crc32.c?  (I
hope so)

 - R.