Subject: Re: [PATCH 14/23 v3] mlx4_core: Determine primary physical function

From: Roland Dreier <[email-masked]>
Date: Thu, 04 Feb 2010 14:30:41 -0800

> +	MLX4_FLAG_PF		= 1 << 5,

Am I mistaken, or is this the only place this flag appears anywhere in
the patch set?  In other words it is never set and never tested -- so
probably we don't need it?

 > +	dev_cap->pf_num = field;
 > +	if (dev_cap->pf_num > 1)
 > +		dev->flags |= MLX4_FLAG_MASTER;

Is this correct?  All PFs > 1 are masters?  Or should the test be "== 1"
rather than "> 1" instead?
-- 
Roland Dreier <[email-masked]>
Cisco.com - http://www.cisco.com

For corporate legal information go to:
http://www.cisco.com/web/about/doing_business/legal/cri/index.html