Subject: Re: [PATCH 2/6] ehea: pHYP interface

From: Roland Dreier <[email-masked]>
Date: Wed, 21 Jun 2006 08:36:05 -0700

I think this code needs to be refactored so that it can share with the
ehca InfiniBand driver (which should be merged upstream soon).  For
example, you have ehea_hcall_7arg_7ret() and the ehca driver has an
identical ehca_hcall_7arg_7ret().

Also:

 > +++ kernel/drivers/net/ehea/ehea_hcall.h	2006-06-21 04:44:50.158485520 -0700

 > +/**
 > + * This file contains HCALL defines that are to be included in the appropriate
 > + * kernel files later
 > + */

this stuff should go in <asm-powerpc/hvcall.h> with the other
constants, right?